-
Notifications
You must be signed in to change notification settings - Fork 831
Convert vsintegration projects to .NET Core SDK #4317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is looking great - it will be such a relief to have this done |
|
@dotnet-bot test Ubuntu16.04 Release_default Build please |
This also includes removing a bunch of dead code that was incorrectly getting globbed into the <Compile> group.
|
@smoothdeveloper What version of Visual Studio and MSBuild do you have installed? As for the 14.0 and 15.0 versions of the Microsoft.VisualStudio.Shell package, both are needed, but duplicate type information should be handled by the Also, have you cleaned the repo? There might be some stuff left over in the |
|
@brettfo thanks for the explanations. I'm using (edit: VS2017 Community 15.6.4) I tried from a clean clone and still having the errors: buildlog.txt |
|
tl;dr - The evaluation order of targets appears to have changed. I'm looking into it now. @smoothdeveloper Now I'm seeing the same thing on my box. Doing a quick look it appears that the Edit: I've created PR #4646 which gets me building on my local box again. We'll see if it passes CI. |


Eventually we'll properly use
Directory.Build.propsandDirectory.Build.targets, but for the time being I don't want the non-SDK projects contaminated, so I opted to name everythingFSharp.Directory.Build.props/.targetsand opt-in each project by adding it's ownDirectory.Build.props/.targetsnext to the converted project files that redirects to theFSharp.ones.To properly handle restoring
<PackageReference />items,NuGet.confighad to be moved to the root of the repo so that it's always up-path from every project file.Also, to enable overriding the F# SDK targets, the
-protosuffix had to be removed. The proto compiler is still built into it's own directory, though, so there won't be any conflicts.All projects under the
vsintegration/directory have been converted to the new SDK except the property pages because that was giving me no end of grief and ultimately the projects are being converted to enable daily testing of the new project system work and the property pages project is VB anyways.