Remove repeating arguments processing in IncrementalBuilder creation #4124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
approved these changes
Dec 16, 2017
Contributor
forki
left a comment
forki
left a comment
There was a problem hiding this comment.
Fixing stuff by deleting code?
Member
Author
|
@forki Yep, a pleasant way to fix something. I cannot say it was actually broken anyways. :) |
auduchinok
force-pushed
the
tcConfigB-creation-targetProfile
branch
from
4897d1d to
287191d
Compare
dsyme
approved these changes
Dec 19, 2017
KevinRansom
approved these changes
Dec 21, 2017
KevinRansom
pushed a commit
that referenced
this pull request
Dec 22, 2017
* fix resource name (#4151) otherwise instead of expected `FSStrings.resources` will use `FSharp.Compiler.Service.netstandard.FSStrings.resources` * Use ConcurrentDictionary in ImportMap (#4148) * Fix IndexOutOfRangeException in check for providing completion (#4138) * Fix IndexOutOfRange in check for providing completion: * Add test * Remove repeating arguments processing in IncrementalBuilder creation (#4124) * Report builder creation warnings according to compiler args (#4125) * Filter incremental builder creation errors according to compiler args * Fix CompilationErrorLogger ignores WarsAsError options * Add test for WarnAsError * Cleanup * Add more tests; cover WarnAsError-, no warnings at all * Refactor tests * Add test
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* fix resource name (dotnet#4151) otherwise instead of expected `FSStrings.resources` will use `FSharp.Compiler.Service.netstandard.FSStrings.resources` * Use ConcurrentDictionary in ImportMap (dotnet#4148) * Fix IndexOutOfRangeException in check for providing completion (dotnet#4138) * Fix IndexOutOfRange in check for providing completion: * Add test * Remove repeating arguments processing in IncrementalBuilder creation (dotnet#4124) * Report builder creation warnings according to compiler args (dotnet#4125) * Filter incremental builder creation errors according to compiler args * Fix CompilationErrorLogger ignores WarsAsError options * Add test for WarnAsError * Cleanup * Add more tests; cover WarnAsError-, no warnings at all * Refactor tests * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4039.