Report builder creation warnings according to compiler args #4125
Conversation
auduchinok
force-pushed
the
builder-creation-errors-severity
branch
3 times, most recently
from
5124346 to
2cdd6f5
Compare
auduchinok
force-pushed
the
builder-creation-errors-severity
branch
from
2cdd6f5 to
70318c7
Compare
auduchinok
changed the title
auduchinok
force-pushed
the
builder-creation-errors-severity
branch
2 times, most recently
from
d5326c3 to
4f0a180
Compare
|
It turned out CompilationErrorLogger didn't change error severities according to error severity options. I fixed it and now I'm waiting for the tests results to check whether anything else needs to be fixed. |
auduchinok
force-pushed
the
builder-creation-errors-severity
branch
from
4f0a180 to
d21b248
Compare
saul
left a comment
saul
left a comment
There was a problem hiding this comment.
Can you also add a test case for —warnaserror-:##? This makes a warning a warning when warnings as errors is enabled.
|
@saul Done. |
|
Cheers! Looks great |
auduchinok
changed the title
| | None -> failwith "declaration list is empty" | ||
|
|
||
|
|
||
| [<TestCase(([||]: string[]), ([||]: bool[]))>] |
There was a problem hiding this comment.
This isn't urgent, but just to say that I personally never use TestCase attributes in the F# tests, and prefer a loop over an F# list of test case data inputs. Indeed I usually remove any uses of TestCase when I come across them later
While using TestCase attribute has some advantages (e.g. they get reported as separate tests in a test explorer), I believe that just using F# code to program the space of test cases is more uniform and in the long run easier to understand - and encourages people to be really expansive in how they meta-program up a very broad range of systematic test cases.
There was a problem hiding this comment.
(Programming up the test case matrix with F# data is also more typesafe of course)
|
Thanks for this. |
* fix resource name (#4151) otherwise instead of expected `FSStrings.resources` will use `FSharp.Compiler.Service.netstandard.FSStrings.resources` * Use ConcurrentDictionary in ImportMap (#4148) * Fix IndexOutOfRangeException in check for providing completion (#4138) * Fix IndexOutOfRange in check for providing completion: * Add test * Remove repeating arguments processing in IncrementalBuilder creation (#4124) * Report builder creation warnings according to compiler args (#4125) * Filter incremental builder creation errors according to compiler args * Fix CompilationErrorLogger ignores WarsAsError options * Add test for WarnAsError * Cleanup * Add more tests; cover WarnAsError-, no warnings at all * Refactor tests * Add test
* fix resource name (dotnet#4151) otherwise instead of expected `FSStrings.resources` will use `FSharp.Compiler.Service.netstandard.FSStrings.resources` * Use ConcurrentDictionary in ImportMap (dotnet#4148) * Fix IndexOutOfRangeException in check for providing completion (dotnet#4138) * Fix IndexOutOfRange in check for providing completion: * Add test * Remove repeating arguments processing in IncrementalBuilder creation (dotnet#4124) * Report builder creation warnings according to compiler args (dotnet#4125) * Filter incremental builder creation errors according to compiler args * Fix CompilationErrorLogger ignores WarsAsError options * Add test for WarnAsError * Cleanup * Add more tests; cover WarnAsError-, no warnings at all * Refactor tests * Add test
4 participants
Fixes #4030.