Skip to content

Conversation

@Krzysztof-Cieslak
Copy link
Contributor

@vasily-kirichenko
Copy link
Contributor

D:\j\w\debug_windows---2f360ea4\src\fsharp\vs\service.fs(905,40): error FS0002: This function takes too many arguments, or is used in a context where a function is not expected

@Krzysztof-Cieslak
Copy link
Contributor Author

@vasily-kirichenko, yes I've seen it. That's what happens if you send PRs from the train without working editor tooling ;-)

Will fix later today

false)

/// Determines if a long ident is resolvable at a specific point.
member scope.IsRelativeNameResolvableFromSymbol(cursorPos: pos, plid: string list, symbol: FSharpSymbol) : bool =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the prettiest name but it will do :)

@dsyme
Copy link
Contributor

dsyme commented Oct 10, 2017

I'm ok with this. @vasily-kirichenko Do you think we need to add specific tests or is existing coverage of IsRelativeNameResolvable enough?

@vasily-kirichenko
Copy link
Contributor

@dsyme we don't have any tests for IsRelativeNameResolvable :(

@Krzysztof-Cieslak
Copy link
Contributor Author

If it's OK then I'd appreciate merge and getting FCS release with it 🙂

@dsyme
Copy link
Contributor

dsyme commented Oct 10, 2017

@Krzysztof-Cieslak Could you add a test please under tests\service? thanks

@KevinRansom
Copy link
Contributor

@dotnet-bot test this please

@KevinRansom KevinRansom merged commit 72e28fe into dotnet:master Oct 17, 2017
@Krzysztof-Cieslak Krzysztof-Cieslak deleted the IsRelativeNameResolvable_public branch October 17, 2017 18:28
@Krzysztof-Cieslak
Copy link
Contributor Author

@KevinRansom, thanks for merging.

@dsyme, I'll add tests in other PR, when I find some time to write it ;) I would be super happy if you could release FCS version with it, so we can use it in FSAC :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants