-
Notifications
You must be signed in to change notification settings - Fork 831
Add IsRelativeNameResolvableFromSymbol
#3722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IsRelativeNameResolvableFromSymbol
#3722
Conversation
|
|
@vasily-kirichenko, yes I've seen it. That's what happens if you send PRs from the train without working editor tooling ;-) Will fix later today |
| false) | ||
|
|
||
| /// Determines if a long ident is resolvable at a specific point. | ||
| member scope.IsRelativeNameResolvableFromSymbol(cursorPos: pos, plid: string list, symbol: FSharpSymbol) : bool = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the prettiest name but it will do :)
|
I'm ok with this. @vasily-kirichenko Do you think we need to add specific tests or is existing coverage of IsRelativeNameResolvable enough? |
|
@dsyme we don't have any tests for |
|
If it's OK then I'd appreciate merge and getting FCS release with it 🙂 |
|
@Krzysztof-Cieslak Could you add a test please under tests\service? thanks |
|
@dotnet-bot test this please |
|
@KevinRansom, thanks for merging. @dsyme, I'll add tests in other PR, when I find some time to write it ;) I would be super happy if you could release FCS version with it, so we can use it in FSAC :-) |
Continuation of fsharp/fsharp-compiler-docs#823