-
Notifications
You must be signed in to change notification settings - Fork 833
Parser: capture named fields block separators #18857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
T-Gro
merged 66 commits into
dotnet:main
from
edgarfgp:capture-named-fields-block-separators
Aug 27, 2025
Merged
Parser: capture named fields block separators #18857
T-Gro
merged 66 commits into
dotnet:main
from
edgarfgp:capture-named-fields-block-separators
Aug 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run ilverify |
🔧 CLI Command Report
✅ Command succeeded, no changes needed. |
…garfgp/fsharp into capture-named-fields-block-separators
8f19aee to
f8c969a
Compare
f8c969a to
532955c
Compare
T-Gro
reviewed
Aug 25, 2025
…garfgp/fsharp into capture-named-fields-block-separators
T-Gro
reviewed
Aug 26, 2025
T-Gro
reviewed
Aug 26, 2025
T-Gro
approved these changes
Aug 26, 2025
auto-merge was automatically disabled
August 26, 2025 16:37
Head branch was pushed to by a user without write access
Co-authored-by: Tomas Grosup <[email protected]>
This reverts commit ec60f7e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I propose we captured the block separators in the same way we do it when we do it records
This is a pre-requisite for #18833 where we need to able to track the separator.
BEFORE
AFTER
Checklist