Add "," as separator for pattern matching on multiple named discriminated unions fields #18833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated unions fields
❗ Release notes required
|
T-Gro
reviewed
Aug 12, 2025
tests/FSharp.Compiler.ComponentTests/Conformance/PatternMatching/NamedPatPairs/NamedPatPairs.fs
Outdated
Show resolved
Hide resolved
edgarfgp
commented
Aug 15, 2025
| | SyntaxNode.SynExpr(SynExpr.Record(None, _, fields, _)) :: _ -> | ||
| let isFirstField = | ||
| match field, fields with | ||
| | Some contextLid, SynExprRecordField(fieldName = lid, _) :: _ -> contextLid.Range = lid.Range |
There was a problem hiding this comment.
The existing pattern matching code seems incorrect - it was missing the tuple parentheses that should have been there. fieldName = lid, _ should have been fieldName = (lid, _).
edgarfgp
commented
Aug 15, 2025
| match recordFields with | ||
| | [] -> false | ||
| | SynExprRecordField(expr = Some(SynExpr.Paren(expr = Is inner)); blockSeparator = Some _) :: SynExprRecordField( | ||
| fieldName = SynLongIdent(id = id :: _), _) :: _ -> problematic inner.Range id.idRange |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements fsharp/fslang-suggestions#957
Checklist