Skip to content

unflake AsyncModule tests #18781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

unflake AsyncModule tests #18781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncModule.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ open System.Threading
open System.Threading.Tasks
open FSharp.Core.UnitTests.LibraryTestFx
open Xunit
open FsCheck
open FSharp.Test

#nowarn "3397" // This expression uses 'unit' for an 'obj'-typed argument. This will lead to passing 'null' at runtime.
// Why warned - the tests here are actually trying to assert that Async<unit> still works.
Expand Down Expand Up @@ -151,6 +151,7 @@ module LeakUtils =

// ---------------------------------------------------

[<Collection(nameof NotThreadSafeResourceCollection)>]
type AsyncModule() =

/// Simple asynchronous task that delays 200ms and returns a list of the current tick count
Expand Down Expand Up @@ -393,7 +394,7 @@ type AsyncModule() =

// Wait for the test to start then dispose waithandle - nothing should happen.
started.Wait()
Assert.False(test.Wait 100, "Test completed too early.")
Assert.False(test.Wait 1000, "Test completed too early.")
printfn "disposing"
dispose wh
printfn "cancelling in 1 second"
Expand Down
Loading