Skip to content

More improve completion after method/property override #18341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 17, 2025
Merged

More improve completion after method/property override #18341

merged 11 commits into from
Mar 17, 2025

Conversation

@ijklam
Copy link
Contributor

@ijklam ijklam commented Feb 26, 2025 •
edited
Loading

Description

  1. Make indent in generated code depend on the context, not fix to 4.
  2. Add a switch to determine whether to generate an default implementation body for overridden method when completing. (See Improve completion after method/property override #17292 (comment))

图片

When checked:

GIF 2025-2-26 21-42-33

When unchecked:

GIF 2025-2-26 21-44-31

Checklist

  • Test cases added
  • Performance benchmarks added in case of performance changes
  • Release notes entry updated:

@ijklam ijklam requested a review from a team as a code owner February 26, 2025 13:46
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025 •
edited
Loading

✅ No release notes required

@psfinaki
Copy link
Contributor

psfinaki commented Mar 5, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

psfinaki
psfinaki reviewed Mar 5, 2025
View reviewed changes
Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a nice feature!

Some minimal testing would be nice, otherwise - I think this is generally good to go.

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Mar 10, 2025
@T-Gro T-Gro enabled auto-merge (squash) March 10, 2025 16:13
auto-merge was automatically disabled March 13, 2025 12:45

Head branch was pushed to by a user without write access

@ijklam
Copy link
Contributor Author

ijklam commented Mar 13, 2025

How to fix this test? fsharp-ci (Build EndToEndBuildTests experimental_features)
fsharp-ci (Build EndToEndBuildTests experimental_features)

The log:

dotnet pack BasicProvider\BasicProvider.fsproj -o D:\a_work\1\s\tests\EndToEndBuildTests\BasicProvider\artifacts -c Release -v minimal -p:FSharpTestCompilerVersion=net40
Determining projects to restore...
D:\a_work\1\s\tests\EndToEndBuildTests\BasicProvider\BasicProvider\BasicProvider.fsproj : error MSB4057: The target "_GetRestoreSettingsPerFramework" does not exist in the project. [TargetFramework=net9.0]

@psfinaki
Copy link
Contributor

Hi @ijklam it's now failing everywhere - not your fault. We're looking into that, sorry.

@Martin521 Martin521 mentioned this pull request Mar 13, 2025
Merged
@T-Gro T-Gro enabled auto-merge (squash) March 14, 2025 13:43
@T-Gro T-Gro merged commit f007405 into dotnet:main Mar 17, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ijklam @psfinaki @T-Gro