Improve completion after method/property override #17292
Conversation
support static member override completion support get completions from generic base type for interface implementation and obj expr
support dotnet#16562 for C# style extension method
more type completion after colon override completion after `member` in interface or object expreesion interface name completion after `interface` class or interface name completion after `new` of object expression
format code
static thing completion show in short name
…ent-90/fsharp into completion-after-op-improve
❗ Release notes required
|
|
Thanks for this, looking forward to have this in the editor! Need to think a bit if this can have any perf traps or penalties, overall - good change and testing. |
Fix completion for same signature slot in different type/interface Fix parameter name generation Adjust code
There was a problem hiding this comment.
So there are quite a few FCS compiler changes here but I cannot see any potential dangers - at the same time, the new functionality is really cool.
@brianrourkeboll maybe you can also take a look at the FCS files, I think you've done some changes there recently.
LGTM, thanks!
|
Can't wait for this PR and the other completions-related PR to land so I can try them out in FSAC :) |
|
(Converted to draft until the parser recovery is adjusted) |
|
Wish there was a way to disable member body completions. It's impossible to use tab to complete member identifiers without it dumping placeholder bodies that I personally find utterly useless and disruptive, and have to manually delete every time. A toggle to revert to #15731 would be ideal. |
|
Or at least make the override completion two-step. Tab for identifier ( + params?), another tab for body. |
|
That'd be cool, but I am not sure VS supports such a flow. |
|
Also, body completions are less relevant nowadays, LLMs pretty much handle it. |
8 participants
Description
Improve completion after method/property override.
Complete the parameter list of the overriden method and call base method or throw
NotImplementedExceptionComplete the parameter list of the overriden property and call base method or throw
NotImplementedExceptionCompletion list will exclude implemented members when triggered in an interface implementation, but not when triggered in an object expression (as cannot get the type of an obj expr from
GetExprTypingForPosition, it just returns the type of interface or the super class)newin object expressionFixes # (issue, if applicable)
Checklist