Skip to content

Better error reporting for unions duplicated fields #17521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 13, 2024
Merged

Better error reporting for unions duplicated fields #17521

merged 7 commits into from
Aug 13, 2024

Conversation

@edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Aug 12, 2024 •
edited
Loading

Description

Continuation of

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@edgarfgp edgarfgp marked this pull request as ready for review August 12, 2024 15:30
@edgarfgp edgarfgp requested a review from a team as a code owner August 12, 2024 15:30
vzarytovskii
vzarytovskii reviewed Aug 12, 2024
View reviewed changes
@vzarytovskii vzarytovskii enabled auto-merge (squash) August 12, 2024 18:30
psfinaki
psfinaki approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Edgar, this is a good addition. Internal errors are awkward!

@vzarytovskii vzarytovskii merged commit 14f4369 into dotnet:main Aug 13, 2024
This was referenced Aug 20, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

+1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edgarfgp @vzarytovskii @psfinaki