Skip to content

Improve error reporting for anonymous records declarations #15824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 21, 2023
Merged

Improve error reporting for anonymous records declarations #15824

merged 7 commits into from
Aug 21, 2023

Conversation

@edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Aug 20, 2023 •
edited
Loading

Currently records and anonymous records show duplicated fields using inconsistent ranges

Screenshot 2023-08-20 144236

This PR shows consistent error ranges in records and anonymous records. See tests

@edgarfgp edgarfgp requested a review from a team as a code owner August 20, 2023 12:46
@edgarfgp edgarfgp changed the title Improve error reporting for anon records declarations Improve error reporting for anonymous records declarations Aug 20, 2023
@edgarfgp
Copy link
Contributor Author

edgarfgp commented Aug 21, 2023 •
edited
Loading

This is ready.
One thing that noticed while working on this. In theory, we should not need the specific 3523. We could use the same diagnostic that records uses to check for duplicated fields. Not sure if removing 3523 will be an option here

abonie
abonie reviewed Aug 21, 2023
View reviewed changes
abonie
abonie reviewed Aug 21, 2023
View reviewed changes
abonie
abonie reviewed Aug 21, 2023
View reviewed changes
@T-Gro T-Gro merged commit 3183d55 into dotnet:main Aug 21, 2023
This was referenced Aug 22, 2023
Merged
Merged
@allisonchou allisonchou mentioned this pull request Aug 25, 2023
Closed
@edgarfgp edgarfgp mentioned this pull request Aug 12, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonie abonie abonie approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edgarfgp @abonie @T-Gro