- 
                Notifications
    You must be signed in to change notification settings 
- Fork 834
Merge main to release/dev17.11 #17360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            KevinRansom
  merged 5 commits into
  release/dev17.11
from
merges/main-to-release/dev17.11
  
      
      
   
  Jun 28, 2024 
      
    
                
     Merged
            
            Merge main to release/dev17.11 #17360
                    KevinRansom
  merged 5 commits into
  release/dev17.11
from
merges/main-to-release/dev17.11
  
      
      
   
  Jun 28, 2024 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    * Random functions: old version rebased * Random functions: Rename functions according to the RFC * Random functions: More naming refactoring and documentation * Random functions: More documentation coments * Random functions: Added randomShuffleInPlace functions and docs * Random functions: refactoring * Added null checks * Added *by functions * Random functions: Array random functions tests * Added tests for lists and seqs * Random functions: addded *By tests to arrays and sequences * Random functions: addded *By tests to lists * Random functions: try fix CI * Random functions: review fixes * Try fix CI * Changed thread local implementation to thread static for performance per review * PR review fix * PR fix * PR review fix * Reverted HashSet constructor improvement since not netstandard2.0 compatible * Fix formatting * Fixed nan case for randomizer function * PR review fixes * PR review changes * Fixed input length check logic for sample --------- Co-authored-by: Petr <[email protected]>
Co-authored-by: Petr <[email protected]>
Co-authored-by: Vlad Zarytovskii <[email protected]>
* TypeProviders: Add inner base-exception description * Release notes docs updated * Update src/Compiler/TypedTree/tainted.fs Thanks @abelbraaksma Co-authored-by: Abel Braaksma <[email protected]> * Update docs/release-notes/.FSharp.Compiler.Service/8.0.400.md Co-authored-by: Abel Braaksma <[email protected]> * Added @abelbraaksma's suggestion --------- Co-authored-by: Abel Braaksma <[email protected]> Co-authored-by: Vlad Zarytovskii <[email protected]> Co-authored-by: Petr <[email protected]>
281a2b0    to
    a6f539d      
    Compare
  
    | ❗ Release notes required
 Warning No PR link found in some release notes, please consider adding it. 
 | 
              
                    KevinRansom
  
              
              approved these changes
              
                  
                    Jun 28, 2024 
                  
              
              
            
            
| /azp run | 
              
                    psfinaki
  
              
              approved these changes
              
                  
                    Jun 28, 2024 
                  
              
              
            
            
| Azure Pipelines successfully started running 2 pipeline(s). | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This is an automatically generated pull request from main into release/dev17.11.
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯
Troubleshooting conflicts
Identify authors of changes which introduced merge conflicts
Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:
Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.
Resolve merge conflicts using your local repo
Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.
git fetch --all git checkout -t upstream/merges/main-to-release/dev17.11 git reset --hard upstream/release/dev17.11 git merge upstream/main # Fix merge conflicts git commit git push upstream merges/main-to-release/dev17.11 --force