Fix nested copy-and-update with complex original expressions #16253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Gro
reviewed
Nov 10, 2023
T-Gro
approved these changes
Nov 10, 2023
kerams
commented
Nov 11, 2023
Contributor
|
This is not necessarily related to this PR but I have been chasing an compiler |
edgarfgp
approved these changes
Nov 11, 2023
Member
|
@kerams Do you know if there are any tests for reported symbols that cover these cases? It would be nice to assert that we still report usages of the symbols in the nested expressions correctly. |
Contributor
Author
|
A couple have been added in #15699 |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16237.
I'm not happy with this solution. I tried to put similar code into
TransformAstForNestedUpdates, but the record checking functions create intermediary bindings too, so then I ended up with duplicates. This works, but feel free to refactor.