Skip to content

Conversation

@kerams
Copy link
Contributor

@kerams kerams commented Jul 27, 2023

Fixes #15696.

@kerams kerams requested a review from a team as a code owner July 27, 2023 18:35
@psfinaki
Copy link
Contributor

@kerams you are breaking GitHub with the name of your branch :D

image

@edgarfgp
Copy link
Contributor

edgarfgp commented Jul 27, 2023

It would be good to add some tests to Symbols.fs?

Edit: We are working on the same codebase area. See #15598. One of us will need to deal with the conflicts :)

@kerams
Copy link
Contributor Author

kerams commented Jul 29, 2023

The current preview also can't handle

type RecordA<'a> = { Foo: 'a; Bar: int; Zoo: RecordA<'a> }

let fz (a: RecordA<int>) = { a with Zoo.Foo = 21; Zoo.Zoo.Bar = 33; Zoo.Bar = 22 }

and doesn't show completions for

let g (a: RecordA<RecordA<int>>) = { a with Foo.F| }

These issues have been taken care of too. I suggest we keep the feature in preview for .NET 8 as there might be further subtle problems.

@vzarytovskii
Copy link
Member

The current preview also can't handle

type RecordA<'a> = { Foo: 'a; Bar: int; Zoo: RecordA<'a> }

let fz (a: RecordA<int>) = { a with Zoo.Foo = 21; Zoo.Zoo.Bar = 33; Zoo.Bar = 22 }

and doesn't show completions for

let g (a: RecordA<RecordA<int>>) = { a with Foo.F| }

These issues have been taken care of too. I suggest we keep the feature in preview for .NET 8 as there might be further subtle problems.

I think it's fine if we put it under 8, it will motivate us to use it and we'll uncover issues faster.

@vzarytovskii vzarytovskii merged commit b9687a5 into dotnet:main Jul 29, 2023
@kerams kerams deleted the Ω branch July 29, 2023 16:24
@kerams
Copy link
Contributor Author

kerams commented Jul 29, 2023

It's your call to decide whether the quality meets the bar ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

F# Symbol is not reported for the outer field when updating a nested field for the second time

4 participants