-
Notifications
You must be signed in to change notification settings - Fork 831
Parser: recover on unfinished type declarations
#15410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
type declarations
...p.Compiler.ComponentTests/Conformance/LexicalFiltering/OffsideExceptions/RelaxWhitespace2.fs
Show resolved
Hide resolved
vsintegration/tests/FSharp.Editor.Tests/DocumentDiagnosticAnalyzerTests.fs
Show resolved
Hide resolved
|
Phew, this one is ready too! 🎉 It was the most difficult to go through the CI so far due to disallowing this: type T with
member this.NoIndentation = 1 // breaks parsing of things belowLike in #15392, it now produces a new indentation warning with the old rules, and an error with the new ones. Deindenting union cases is still allowed as it allows subsequent things to be parsed correctly: type U =
| A // there's an existing special case allowing this for union cases
() |
|
Will this cover the cases unfinished code with types using the using verbose syntax ?. |
|
@edgarfgp Could you elaborate, please? |
|
Sure. I was referring to the cases with type A = class //end --missing end
type I = interface // --missing end
|
|
I see, thanks. |
f71489d to
91c6d48
Compare
Various unfinished
typecases:typeUnfinished types ending with
withand=are recovered due to the new indentation rules.