Skip to content

Conversation

@auduchinok
Copy link
Member

Implements recovery for cases like this:

type T =
    do

    do ()

Also slightly improves recovery messages for unfinished while/for expressions. Hopefully, this doesn't break the code completion again. 🙂

@auduchinok auduchinok requested a review from a team as a code owner June 14, 2023 14:58
@auduchinok auduchinok changed the title Parser: recover on unfinished do members with new indentation rules Parser: recover on unfinished do members Jun 14, 2023
@auduchinok
Copy link
Member Author

This is ready.

GitHub doesn't seem to see that Build Source-Build Complete is finished successfully for some reason: https://dev.azure.com/dnceng-public/public/_build/results?buildId=307022&view=results

@T-Gro T-Gro enabled auto-merge (squash) June 14, 2023 16:46
@auduchinok auduchinok closed this Jun 15, 2023
auto-merge was automatically disabled June 15, 2023 13:36

Pull request was closed

@auduchinok auduchinok reopened this Jun 15, 2023
@auduchinok
Copy link
Member Author

It's green. 🙂

Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@psfinaki psfinaki merged commit af18bf0 into dotnet:main Jun 15, 2023
@auduchinok auduchinok deleted the lexFilter-strict6 branch June 15, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants