Fix bug in return type hints #15124
Merged
Fix bug in return type hints #15124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonie
approved these changes
Apr 20, 2023
psfinaki
approved these changes
Apr 20, 2023
Contributor
psfinaki
left a comment
psfinaki
left a comment
There was a problem hiding this comment.
So that's a bug in the compiler actually? I am surprised nothing else is affected but well okay :)
Contributor
Author
No, I made that function for return type hints (actually you made me put it there 😀) and nothing else uses it. I copied that particular part from |
Contributor
|
Ah right. Okay then, thanks! |
vzarytovskii
added a commit
that referenced
this pull request
Apr 25, 2023
Co-authored-by: vzarytovskii <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kevin Ransom (msft) <[email protected]> Co-authored-by: Vlad Zarytovskii <[email protected]> Co-authored-by: Tomas Grosup <[email protected]> Co-authored-by: Florian Verdonck <[email protected]> Co-authored-by: Petr <[email protected]> Co-authored-by: Petr Pokorny <[email protected]> Fixing hints for custom ops (#15119) Fix bug in return type hints (#15124)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redundant return type hints are shown when annotation is present with a generic or type parameters.