Skip to content

Fix bug in return type hints #15124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Fix bug in return type hints #15124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8be35d
test
0101 Apr 20, 2023
27b862c
fix
0101 Apr 20, 2023
6ebdf6d
Merge branch 'main' into fix-return-type-hints
0101 Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Compiler/Service/FSharpParseFileResults.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ type FSharpParseFileResults(diagnostics: FSharpDiagnostic[], input: ParsedInput,
| SynBinding(expr = SynExpr.Lambda _) when skipLambdas -> defaultTraverse binding

// Skip manually type-annotated bindings
| SynBinding(returnInfo = Some (SynBindingReturnInfo(typeName = SynType.LongIdent _))) -> defaultTraverse binding
| SynBinding(returnInfo = Some (SynBindingReturnInfo _)) -> defaultTraverse binding

// Let binding
| SynBinding (trivia = { EqualsRange = Some equalsRange }; range = range) when range.Start = symbolUseStart ->
Expand Down
8 changes: 5 additions & 3 deletions vsintegration/tests/FSharp.Editor.Tests/Hints/InlineReturnTypeHintTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,11 @@ let ``Hints are not shown for lambda bindings`` () =

Assert.Empty result

[<Fact>]
let ``Hints are not shown when there's type annotation`` () =
let code = "let func x : int = x"
[<Theory>]
[<InlineData("let func x : int = x")>]
[<InlineData("let func (a: 'a) : 'a = a")>]
[<InlineData("let func (a: 'a) : List<'a> = [a]")>]
let ``Hints are not shown when there's type annotation`` code =

let document = getFsDocument code

Expand Down