Fix: Dynamic assignment operator warning #14495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosskuehl
changed the title
psfinaki
approved these changes
Dec 20, 2022
vzarytovskii
approved these changes
Dec 20, 2022
auduchinok
reviewed
Dec 20, 2022
| let ``Implementing dynamic assignment operator does not produce a warning`` version = | ||
| Fsx """ | ||
| type T = T with | ||
| static member inline (?<-) (f, x, y) = f x y |
Member
There was a problem hiding this comment.
Could some test also include a usage of this operator, maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14011 and #14418
It appears that the operator's display name was being passed to
IsLogicalTernaryOperatorinstead of the logical name, causing thedisplayName <> logicalNamecheck to always return false.I added a test to verify that the change is effective and more descriptive variable names to help clarify the usage.