Skip to content

Fix: Dynamic assignment operator warning #14495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Fix: Dynamic assignment operator warning #14495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a350f30
use logical operator name to check for logical ternary operator
shoyu-ramen Dec 20, 2022
2083398
Merge branch 'main' into fix/dynamic-assignment-operator-warning
rosskuehl Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/Compiler/Checking/CheckExpressions.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1015,15 +1015,16 @@ let MakeMemberDataAndMangledNameForMemberVal(g, tcref, isExtrinsic, attrs, implS

if not isCompGen && IsLogicalInfixOpName id.idText then
let m = id.idRange
let name = ConvertValLogicalNameToDisplayNameCore id.idText
let logicalName = id.idText
let displayName = ConvertValLogicalNameToDisplayNameCore logicalName
// Check symbolic members. Expect valSynData implied arity to be [[2]].
match SynInfo.AritiesOfArgs valSynData with
| [] | [0] -> warning(Error(FSComp.SR.memberOperatorDefinitionWithNoArguments name, m))
| [] | [0] -> warning(Error(FSComp.SR.memberOperatorDefinitionWithNoArguments displayName, m))
| n :: otherArgs ->
let opTakesThreeArgs = IsLogicalTernaryOperator name
if n<>2 && not opTakesThreeArgs then warning(Error(FSComp.SR.memberOperatorDefinitionWithNonPairArgument(name, n), m))
if n<>3 && opTakesThreeArgs then warning(Error(FSComp.SR.memberOperatorDefinitionWithNonTripleArgument(name, n), m))
if not (isNil otherArgs) then warning(Error(FSComp.SR.memberOperatorDefinitionWithCurriedArguments name, m))
let opTakesThreeArgs = IsLogicalTernaryOperator logicalName
if n<>2 && not opTakesThreeArgs then warning(Error(FSComp.SR.memberOperatorDefinitionWithNonPairArgument(displayName, n), m))
if n<>3 && opTakesThreeArgs then warning(Error(FSComp.SR.memberOperatorDefinitionWithNonTripleArgument(displayName, n), m))
if not (isNil otherArgs) then warning(Error(FSComp.SR.memberOperatorDefinitionWithCurriedArguments displayName, m))

if isExtrinsic && IsLogicalOpName id.idText then
warning(Error(FSComp.SR.tcMemberOperatorDefinitionInExtrinsic(), id.idRange))
Expand Down
1 change: 1 addition & 0 deletions tests/FSharp.Compiler.ComponentTests/FSharp.Compiler.ComponentTests.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@
<Compile Include="Language\CodeQuotationTests.fs" />
<Compile Include="Language\InterpolatedStringsTests.fs" />
<Compile Include="Language\ComputationExpressionTests.fs" />
<Compile Include="Language\DynamicAssignmentOperatorTests.fs" />
<Compile Include="Language\CastingTests.fs" />
<Compile Include="Language\NameofTests.fs" />
<Compile Include="Language\ExtensionMethodTests.fs" />
Expand Down
21 changes: 21 additions & 0 deletions tests/FSharp.Compiler.ComponentTests/Language/DynamicAssignmentOperatorTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
// Copyright (c) Microsoft Corporation. All Rights Reserved. See License.txt in the project root for license information.

namespace FSharp.Compiler.ComponentTests.Language

open System
open Xunit
open FSharp.Test.Compiler

module DynamicAssignmentOperatorTests =

[<Theory>]
[<InlineData("6.0")>]
[<InlineData("7.0")>]
let ``Implementing dynamic assignment operator does not produce a warning`` version =
Fsx """
type T = T with
static member inline (?<-) (f, x, y) = f x y
Copy link
Member

@auduchinok auduchinok Dec 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could some test also include a usage of this operator, maybe?

"""
|> withLangVersion version
|> compile
|> shouldSucceed