Skip to content

debug fsharpqa tests #14298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 14, 2022
Merged

debug fsharpqa tests #14298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e3ae246
debug fsharpqa tests
KevinRansom Nov 11, 2022
88c4b6f
temp
KevinRansom Nov 11, 2022
817e077
temp
KevinRansom Nov 11, 2022
7dcb529
Merge branch 'main' into movedebugtests
KevinRansom Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions tests/FSharp.Compiler.ComponentTests/CompilerOptions/fsc/debug.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
// Copyright (c) Microsoft Corporation. All Rights Reserved. See License.txt in the project root for license information.

namespace FSharp.Compiler.ComponentTests.CompilerOptions

open Xunit
open FSharp.Test
open FSharp.Test.Compiler

module debug =

[<Fact>]
let ``fsc debug``() =
FSharp """
printfn "Hello, World"
"""
|> asExe
|> withOptions ["--debug"]
|> compile
|> shouldSucceed
|> verifyHasPdb

[<Fact>]
let ``fsc debug plus``() =
FSharp """
printfn "Hello, World"
"""
|> asExe
|> withOptions ["--debug+"]
|> compile
|> shouldSucceed
|> verifyHasPdb

[<Fact>]
let ``fsc debug minus``() =
FSharp """
printfn "Hello, World"
"""
|> asExe
|> withOptions ["--debug-"]
|> compile
|> shouldSucceed
|> verifyNoPdb
1 change: 1 addition & 0 deletions tests/FSharp.Compiler.ComponentTests/FSharp.Compiler.ComponentTests.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@
<Compile Include="TypeChecks\ParallelCheckingWithSignatureFilesTests.fs" />
<Compile Include="CompilerOptions\fsc\checked\checked.fs" />
<Compile Include="CompilerOptions\fsc\cliversion.fs" />
<Compile Include="CompilerOptions\fsc\debug.fs" />
<Compile Include="CompilerOptions\fsc\langversion.fs" />
<Compile Include="CompilerOptions\fsc\noframework\noframework.fs" />
<Compile Include="CompilerOptions\fsc\platform\platform.fs" />
Expand Down
24 changes: 24 additions & 0 deletions tests/FSharp.Test.Utilities/Compiler.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,6 +1072,30 @@ module rec Compiler =

result

let verifyHasPdb (result: CompilationResult): unit =
let verifyPdbExists r =
match r.OutputPath with
| Some assemblyPath ->
let pdbPath = Path.ChangeExtension(assemblyPath, ".pdb")
if not (FileSystem.FileExistsShim pdbPath) then
failwith $"PDB file does not exists: {pdbPath}"
| _ -> failwith "Output path is not set, please make sure compilation was successfull."
match result with
| CompilationResult.Success r -> verifyPdbExists r
| _ -> failwith "Result should be \"Success\" in order to verify PDB."

let verifyNoPdb (result: CompilationResult): unit =
let verifyPdbNotExists r =
match r.OutputPath with
| Some assemblyPath ->
let pdbPath = Path.ChangeExtension(assemblyPath, ".pdb")
if FileSystem.FileExistsShim pdbPath then
failwith $"PDB file exists: {pdbPath}"
| _ -> failwith "Output path is not set, please make sure compilation was successfull."
match result with
| CompilationResult.Success r -> verifyPdbNotExists r
| _ -> failwith "Result should be \"Success\" in order to verify PDB."

[<AutoOpen>]
module Assertions =
let private getErrorNumber (error: ErrorType) : int =
Expand Down
37 changes: 0 additions & 37 deletions tests/fsharpqa/Source/CompilerOptions/fsc/debug/debug01.fs
View file
Open in desktop

This file was deleted.

37 changes: 0 additions & 37 deletions tests/fsharpqa/Source/CompilerOptions/fsc/debug/debug02.fs
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions tests/fsharpqa/Source/CompilerOptions/fsc/debug/env.lst
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion tests/fsharpqa/Source/Conformance/DeclarationElements/ObjectConstructors/env.lst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
SOURCE=E_NoLetBindingsWOObjCtor.fs # E_NoLetBindingsWOObjCtor.fs
SOURCE=E_NoObjectConstructorOnInterfaces.fs # E_NoObjectConstructorOnInterfaces.fs

SOURCE=AlternateGenericTypeSyntax01.fs # AlternateGenericTypeSyntax01.fs
SOURCE=AlternateGenericTypeSyntax01.fs SCFLAGS="--langversion:5.0" # AlternateGenericTypeSyntax01.fs
SOURCE=MutuallyRecursive01.fs # MutuallyRecursive01.fs
SOURCE=ImplicitCtorsCallingBaseclassPassingSelf.fs # ImplicitCtorsCallingBaseclassPassingSelf.fs

Expand Down
19 changes: 8 additions & 11 deletions tests/fsharpqa/Source/test.lst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,39 +5,36 @@
# ReqNOCov -- skip this test/suite if we are doing a code coverage run
# ReqENU -- skip this test/suite if we are running on non-ENU (useful to exclude hard-to-localize tests)

CompilerOptions01,NoMT CompilerOptions\fsc\checked
CompilerOptions01,NoMT CompilerOptions\fsc\cliversion
CompilerOptions01,NoMT CompilerOptions\fsc\codepage
CompilerOptions01,NoMT CompilerOptions\fsc\crossoptimize
CompilerOptions01,NoMT CompilerOptions\fsc\debug
CompilerOptions01,NoMT,Determinism CompilerOptions\fsc\determinism
CompilerOptions01,NoMT CompilerOptions\fsc\dumpAllCommandLineOptions
CompilerOptions01,NoMT CompilerOptions\fsc\flaterrors
CompilerOptions02,NoMT CompilerOptions\fsc\gccerrors
CompilerOptions01,NoMT,help CompilerOptions\fsc\help
CompilerOptions01,NoMT,help CompilerOptions\fsc\help
CompilerOptions01,NoMT CompilerOptions\fsc\highentropyva
CompilerOptions01,NoMT CompilerOptions\fsc\langversion
CompilerOptions01,NoMT CompilerOptions\fsc\lib
CompilerOptions01,NoMT CompilerOptions\fsc\noframework
CompilerOptions01,NoMT CompilerOptions\fsc\nologo
CompilerOptions01,NoMT CompilerOptions\fsc\optimize
CompilerOptions01,NoMT CompilerOptions\fsc\out
CompilerOptions01,NoMT,pdbs CompilerOptions\fsc\pdb
CompilerOptions01,NoMT CompilerOptions\fsc\platform
CompilerOptions01,NoMT,pdbs CompilerOptions\fsc\pdb
CompilerOptions01,NoMT CompilerOptions\fsc\Removed
CompilerOptions01,NoMT CompilerOptions\fsc\responsefile
CompilerOptions01,NoMT CompilerOptions\fsc\standalone
CompilerOptions01,NoMT,NoHostedCompiler CompilerOptions\fsc\staticlink
CompilerOptions01,NoMT,NoHostedCompiler CompilerOptions\fsc\staticlink
CompilerOptions01,NoMT CompilerOptions\fsc\subsystemversion
CompilerOptions01,NoMT CompilerOptions\fsc\tailcalls
CompilerOptions01,NoMT CompilerOptions\fsc\target
CompilerOptions01,NoMT,NoHostedCompiler CompilerOptions\fsc\tokenize
CompilerOptions01,NoMT CompilerOptions\fsc\responsefile
CompilerOptions01,NoMT,help CompilerOptions\fsi\help
CompilerOptions01,NoMT,NoHostedCompiler CompilerOptions\fsc\tokenize

CompilerOptions01,NoMT,help CompilerOptions\fsi\help
CompilerOptions01,NoMT CompilerOptions\fsi\highentropyva
CompilerOptions01,NoMT CompilerOptions\fsi\langversion
CompilerOptions01,NoMT CompilerOptions\fsi\nologo
CompilerOptions01,NoMT CompilerOptions\fsi\subsystemversion
CompilerOptions02,NoMT CompilerOptions\fsi\exename
CompilerOptions01,NoMT,Determinism CompilerOptions\fsc\determinism

Conformance01 Conformance\BasicGrammarElements\Constants
Conformance01 Conformance\BasicGrammarElements\OperatorNames
Expand Down