Skip to content

debug fsharpqa tests #14298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 14, 2022
Merged

debug fsharpqa tests #14298

merged 4 commits into from
Nov 14, 2022

Conversation

@KevinRansom
Copy link
Contributor

@KevinRansom KevinRansom commented Nov 11, 2022

Fixes: #14296

And moves a couple more tests from fsharpqa.

@KevinRansom KevinRansom requested a review from a team as a code owner November 11, 2022 07:39
@T-Gro
Copy link
Member

T-Gro commented Nov 11, 2022

Conformance\DeclarationElements\ObjectConstructors (AlternateGenericTypeSyntax01.fs) -- failed

@T-Gro
Copy link
Member

T-Gro commented Nov 11, 2022

When trying the same code, I think it correctly reports an error:
https://sharplab.io/#v2:EYLgxg9gTgpgtADwGwBYA0AbEAzAzgHwHpCACAYgCUYBzWXXASwgDtyBhF7aAWwENmwMcgBEYYDLyi8ALk2YBRDDG4xm03OQDywAFZjpHZrmlQArmGnQNAWABQZDA2oALaXbvESAFRjGSXKBJeDGkYKGYZIVwATzVeBH9oEgATMQkoBmZqEmpVMIYwEmlogAdfD1IvZwYNZghpGTkSSBUNbCgIbhJNNl5uDCDmZJIa3FNfQe7e/rgWkpkSAHdJZkzqd1tPAHJeNBIt4BI2CXoAOT6YCpIAN1wAOivj3jOLgB4dvYOAPg3ispIABQffbAACUJAAypZYAA1YLjXAA3gkED7XYkQ6og7ggC8JDsJEJJBU3GAYSK1XucIw4wAjCQ8bwCUSSWTAtJKXdqeMAEwMjEbTwAzLSPbGDJZcFQ6Awbm+AG0gAMPPQJAARGBnGrQVdbg9NqRpbD4b5XiKxSY1l8FcrVRqtTrbEppEV+cwYItAeaSOK1lLobKTYilSq9vbtXYGNgilyTfTXl8SCGUBTVCQYAgGC7aZHo9JYzSYHyE+rNWrU6wM1mkxsqy7FUA===

I have absolutely 0 clue how this might be related with the change just done...

psfinaki
psfinaki approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@psfinaki psfinaki merged commit 80a23ee into dotnet:main Nov 14, 2022
@allisonchou allisonchou mentioned this pull request Nov 21, 2022
Closed
@KevinRansom KevinRansom deleted the movedebugtests branch January 13, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonie abonie abonie approved these changes

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fsharpqa tests fail on my machine:

4 participants

@KevinRansom @T-Gro @psfinaki @abonie