Inline type hints for F# #14159
Merged
Inline type hints for F# #14159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psfinaki
requested review from
0101,
KevinRansom,
T-Gro,
abonie,
dsyme and
vzarytovskii
vzarytovskii
requested changes
Oct 21, 2022
Member
|
General question - why using sequences everywhere, if in the end it's eager and still getting converted to an array? Edit: oh, I guess because of |
T-Gro
requested changes
Oct 24, 2022
Member
|
@psfinaki could you please change task to async? After that we can merge it. |
Contributor
Author
|
@vzarytovskii working on that :) |
T-Gro
approved these changes
Oct 25, 2022
vzarytovskii
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes and closes #12928
Closes #14158
See the feature in action:
output.mp4