[BLOCKED] Visual Studio implementation of Inline Hints #12928
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Note the following behavior: * Type hints are at definition/binding, not use * Type hints do not show if something already has an annotation * Parameter name hints appear for F# functions and methods, using the named argument syntax * Named parameters get no hints * Lambdas that are let-bound will have a type hint, but other let-bound F# functions will not Out of scope: * Type hints for "normal" function declarations. * It just looks bad and there isn't a good way to play hints without getting smushed together with the type hint for the last parameter. * Lambda function declarations, yes. * Show inferred types for _ in a pattern * Note - this can be done orthogonally and also support quickinfo * Add QuickInfo - * Note, this can be done orthogonally. * We need a way to resolve the symbol we're showing the type for and get quickinfo from * No such API exists in the compiler today
baronfel
force-pushed
the
inlinehints-vs
branch
6 times, most recently
from
9da01f0 to
24e03ed
Compare
This hooks up Inlay Hints to the editor via a new InlineHintsService.
20 tasks
Contributor
|
What are the ergonomics of this? Is there a key combination to show the hints? Or are they on by default? Thanks! |
Contributor
|
I merged in main so reduce the apparent diff |
Member
Author
|
We'd need to hook up options - maybe something from Roslyn would help as a pattern? |
Member
Contributor
|
@vzarytovskii this is a good start and the right way to go. But I'll rather somewhat incorporate this into my changes I'm working on, then will probably close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second PR for the Inline Hints feature (the first is here). It contains only the Visual Studio changes, updated to the latest compiler main branch. No other changes have been made.
Per #10295, the following changes still need to be made: