Compiler error for signature/implementation files when declaring multiple parameters with the same name in abstract methods #14084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
edgarfgp
commented
Oct 11, 2022
edgarfgp
commented
- Supersedes Compiler error when declaring multiple parameters with the same name in abstract methods #13964
- Fixes No compiler error when declaring multiple parameters with the same name in abstract methods #13148
…iple parameters with the same name in abstract methods
…eters-with-the-same-name-in-abstract-methods
T-Gro
previously approved these changes
Oct 12, 2022
0101
previously approved these changes
Oct 12, 2022
psfinaki
previously approved these changes
Oct 12, 2022
...nformance/DeclarationElements/MemberDefinitions/MethodsAndProperties/MethodsAndProperties.fs
Outdated
Show resolved
Hide resolved
…eters-with-the-same-name-in-abstract-methods
…ements/MemberDefinitions/MethodsAndProperties/MethodsAndProperties.fs
Contributor
0101
previously approved these changes
Oct 12, 2022
…eters-with-the-same-name-in-abstract-methods
Contributor
Author
|
@psfinaki it seems like the CI does not like the changes on FSComp.txt . Had the same issue in the past and I had to create a brand new branch and start from scratch 😔 |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
@edgarfgp damn. It's probably worth taking a closer look on why is this happening, will come back to this tomorrow. |
…eters-with-the-same-name-in-abstract-methods
psfinaki
approved these changes
Oct 13, 2022
0101
approved these changes
Oct 13, 2022
Contributor
|
@edgarfgp alright, there it is, thanks again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.