Compiler error when declaring multiple parameters with the same name in abstract methods #13964
Conversation
|
@vzarytovskii I think this is ready :) . Let me know if you are happy with the error message . |
…eters-with-the-same-name-in-abstract-methods
dsyme
left a comment
dsyme
left a comment
There was a problem hiding this comment.
Just some minor de-functionalization requested please
…eters-with-the-same-name-in-abstract-methods
...ormance/DeclarationElements/MemberDefinitions/MethodsAndProperties/E_Abstract_ReusedParam.fs
Show resolved
Hide resolved
…eters-with-the-same-name-in-abstract-methods
…the-same-name-in-abstract-methods' of https://github.com/edgarfgp/fsharp into compiler-error-when-declaring-multiple-parameters-with-the-same-name-in-abstract-methods
dsyme
left a comment
dsyme
left a comment
There was a problem hiding this comment.
This is great but please factor out the common code. I'd like us to start being more rigorous about avoiding code duplication like this in the compiler, when it's easy to do so.
…eters-with-the-same-name-in-abstract-methods
Thanks . I will be more rigorous in my next contributions . I appreciate the patience you have :) |
…eters-with-the-same-name-in-abstract-methods # Conflicts: # src/Compiler/FSComp.txt
…eters-with-the-same-name-in-abstract-methods
…eters-with-the-same-name-in-abstract-methods
…eters-with-the-same-name-in-abstract-methods
…eters-with-the-same-name-in-abstract-methods
…eters-with-the-same-name-in-abstract-methods
…eters-with-the-same-name-in-abstract-methods
edgarfgp
deleted the
compiler-error-when-declaring-multiple-parameters-with-the-same-name-in-abstract-methods
branch
|
Closing this PR :). As I had a CI error with the generated FSComp.txt strings :( . I will create a new PR in a bit |
5 participants
Fixes #13148
Update: I have decided to not fix #13981 as per of this PR as this issue seems t be more complex than what I thought at the beginning