Introduce SynType.SignatureParameter. #13879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, let's totally take this one, @dsyme ready for review. |
dsyme
reviewed
Sep 13, 2022
There was a problem hiding this comment.
Please also adjust
- traverseSynType in ServiceParseTreeWalk
- walkType in
GetEntityKind(what is that funciton anyway? It has so much code walking duplication!)
Maybe also remove the default | _ -> pattern matching in those two cases so these missing cases would have been discovered, and check for other missing cases there
There was a problem hiding this comment.
Thanks, I've addressed the missing cases.
dsyme
requested changes
Sep 13, 2022
nojaf
force-pushed
the
syntype-signature-parameter
branch
from
96cd1a4 to
a9b956b
Compare
dsyme
approved these changes
Sep 14, 2022
vzarytovskii
added a commit
that referenced
this pull request
Sep 14, 2022
* Introduce SynType.SignatureParameter. * Add missing SynType cases in walkers. Co-authored-by: Florian Verdonck <[email protected]> Co-authored-by: Vlad Zarytovskii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A less impactful version of #13855.
In this PR I'm only adding the signature parameter representation, not touching anything related to
SynArgInfo.