Skip to content

Conversation

@nojaf
Copy link
Contributor

@nojaf nojaf commented Sep 6, 2022

Fixes #13848

dsyme
dsyme previously approved these changes Sep 8, 2022
@nojaf nojaf force-pushed the syntype-tuple-parameter-name branch from a5a24bc to d97171f Compare September 15, 2022 07:31
@nojaf
Copy link
Contributor Author

nojaf commented Sep 15, 2022

This is still fixed after taking in #13879

@dsyme
Copy link
Contributor

dsyme commented Sep 23, 2022

@nojaf So we take these tests? That's fine, thanks!

@nojaf
Copy link
Contributor Author

nojaf commented Sep 23, 2022

Yes, please 😊.

@nojaf nojaf force-pushed the syntype-tuple-parameter-name branch from f97cdfd to 753ad18 Compare September 26, 2022 06:06
T-Gro
T-Gro previously approved these changes Oct 7, 2022
@T-Gro T-Gro requested review from 0101, abonie and psfinaki October 7, 2022 11:37
T-Gro
T-Gro previously approved these changes Oct 7, 2022
@vzarytovskii
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@T-Gro T-Gro merged commit fcd06c7 into dotnet:main Oct 7, 2022
@nojaf nojaf deleted the syntype-tuple-parameter-name branch October 7, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SynType.Tuple doesn't include leading parameter names and attributes in signatures

5 participants