Revert FCS compression #13781
Merged
Revert FCS compression #13781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
reviewed
Aug 25, 2022
| <CompressMetadata>true</CompressMetadata> | ||
| <CompressMetadata Condition="'$(CompressAllMetadata)' != 'true'">false</CompressMetadata> | ||
| <NoOptimizationData>true</NoOptimizationData> | ||
| <CompressMetadata Condition="'$(CompressAllMetadata)' != 'true'">false</CompressMetadata> |
Contributor
Author
There was a problem hiding this comment.
yes it is, copy and paste the bane of my life.
vzarytovskii
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My apologies.
In my enthusiasm for sucking the bytes out of the product I made it so no one could use any tooling to work with our repo.
My bad!
Anyway this puts things back into place.
I think we will not compress the FCS metadata until after VS 2022.4 has shipped. So the first RTM FCS with compressed data will be the one that ships with VS 2022.5 ... obviously there will be previews prior to that.
That will ensure that the RTM version of VS and any tools that rely on FCS will have time to adjust. Primarily that means adopting the .Net 7.0 Sdk for builds.