Turn off compressed metadata until VS, vscode, Rider tooling understands it #13778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
changed the title
Contributor
|
Would you mind if I do this a bit differently. We have a build and test leg that compresses and runs tests for everything including FSharp.Core. |
Contributor
|
I believe we should hold off on compressing FCS until, the release of 17.5. That way the latest Sdks and vs will support compressed Metadata. |
Contributor
|
closing in favour of: #13781 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to start working in this repo using existing tooling again
Perhaps there's a way to get the binaries produced for .NET SDK to have compressed metadata, not sure.
Along the way I noticed I'm sceptical of lines like this; https://github.com/dotnet/fsharp/pull/13671/files#diff-69b930c41d928d758d322b5e47f6da0ddc08479a302c199c8aeaa912b6fb5d55R32