Fix broken unit test #12349
Merged
Fix broken unit test #12349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
approved these changes
Nov 6, 2021
Member
vzarytovskii
left a comment
vzarytovskii
left a comment
There was a problem hiding this comment.
Thanks for the fix. I will need to look at the pr which introduced it and understand why did it pass CI.
Contributor
|
@vzarytovskii, I'm guessing because |
Member
Yeah, that was my guess, didn't look at it yet. We probably need to pay closer attention to the after-merge CI status. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codebase is failing to build
The build error was introduced in #11641
This PR fix it and also closes #12348