Printing updates #12072
Merged
Printing updates #12072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
added
the
Theme-Simple-F#
added 12 commits
August 31, 2021 22:18
This was referenced Sep 2, 2021
Contributor
Author
|
@KevinRansom @TIHan @vzarytovskii This is ready However we should first get #12047 in and then I'll integrate (it will take a bit of work) |
Contributor
Author
|
This needs one fix - the Declaration lists now contain Before:
After:
|
Contributor
Author
|
@TIHan This is ready (assuming it goes green) |
Contributor
Author
|
@TIHan ready! :) |
TIHan
approved these changes
Sep 3, 2021
Contributor
TIHan
left a comment
TIHan
left a comment
There was a problem hiding this comment.
This is a large change right before imminent release, but the changes here are really just printing improvements and other minor refactorings. Looks good and excited to see how signature generation has improved :) , as well as tooltips.
This was referenced Sep 3, 2021
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* printing updates * printing updates * fix tests * fix tests * Print 'abstract' instead of 'abstract member' * Print 'abstract' instead of 'abstract member' * update tests * simplify code for laying out type definitions * adjust tests * fix printing of backtick and operator identifiers * update tests * update more tests * multi-line curried signature formatting * don't print literals twice * fix tests * fix tests * fix names in completion list * systematize the demangling (DisplayNameCore) and addition of parens/backticks (DisplayName) * fix a test case * update baseline * fix signature generation and re-enable tests * fix list completion * fix list completion * always show [<Struct>] * always show [<Struct>] Co-authored-by: Don Syme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates signature printing to print in ways that are consistent with the F# style guide
Spacing in printed and generated signatures doesn't follow F# style guide #12090
Printing shows begin/end for modules unnecessarily #12089
Types print as
int []notint[]#12088Literal values are shown twice in F# Interactive outputs #12091
Show 'abstract' not 'abstract member' #12092
Suppress with/end, class/end, interface/end, struct/end from displays when not needed #12093
Signature printing doesn't escape all identifiers correctly #12094
Format multi-line curried signatures according to the preferred style guide proposal https://github.com/dotnet/docs/issues/25917
This part of Printing of type signatures has inaccuracies, especially from --sig:file.fsi #393 (comment)
Another part of Printing of type signatures has inaccuracies, especially from --sig:file.fsi #393 (comment)
Go to Metadata - fully qualified names for members mess up printing #11523 (see sample for System.Char generation)
Go to Metadata - fields in structs issue #11524
FCS change:
symbol.DisplayNamewill now include backticks when they are necessary to make the name a valid identifier. For example previously a symbol with logical nameA-Bwould give( A-B )as the display name, which is not valid F# identifier text. Instead``A-B``will be returned bysymbol.DisplayName.Also cleanup:
TRecdRepr-->TFSharpRecdRepretc. to make it clear they only apply to F#-declared things. This can help when reading code, and also as we increase interop with C# records etc.Some tests to update but all routine.