-
Notifications
You must be signed in to change notification settings - Fork 831
Update version numbers for FSharp.Core #12047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8ef2163 to
a663a1b
Compare
|
Seems only one test failing: |
8d916c0 to
3ad2918
Compare
|
@vzarytovskii , yes it has taken some thought to figure out tmagic for that. |
722e073 to
ad4d1a7
Compare
…ageFeature.AttributesToRightOfModuleKeyword
|
@vzarytovskii , @brettfo --- Assuming it passes this is ready |
|
@KevinRansom I updated tests.fs to remove the test case corresponding to the deleted test files for array-no-dot-warnings in preview |
| type Person = { Name : string; Age : int; City : string } | ||
| let x = { Name = "Isaac", Age = 21, City = "London" } | ||
| """ | ||
| |> withLangVersion50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason this needed langversion 5.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dsyme , indeed yes and amazingly I can even remember why ... the test verified the behaviour without preview [Right Attribute Module Abbreviation without preview (compile)`]. I.e. the old F#5.0 behaviour, so ... this the test became with net50 [Right Attribute Module Abbreviation with version 5.0 (compile)] instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This... isn't the test you are referring to.
Uh oh!
There was an error while loading. Please reload this page.