Skip to content

Conversation

@KevinRansom
Copy link
Contributor

@KevinRansom KevinRansom commented Aug 26, 2021

  FSharp Language Version: 6.0
  FSharp.Core assembly Version: 6.0.0.0
  FSharp.Core package Version: 6.0.0
  FCS assembly version: 41.0.0.0
  FCS package version: 41.0.1
  LanguageFeature.AdditionalTypeDirectedConversions, languageVersion60
  LanguageFeature.RelaxWhitespace2, languageVersion60
  LanguageFeature.OverloadsForCustomOperations, languageVersion60
  LanguageFeature.ExpandedMeasurables, languageVersion60
  LanguageFeature.ResumableStateMachines, languageVersion60
  LanguageFeature.StructActivePattern, languageVersion60
  LanguageFeature.PrintfBinaryFormat, languageVersion60
  LanguageFeature.IndexerNotationWithoutDot, languageVersion60
  LanguageFeature.RefCellNotationInformationals, languageVersion60
  LanguageFeature.UseBindingValueDiscard, languageVersion60
  LanguageFeature.NonVariablePatternsToRightOfAsPatterns, languageVersion60
  LanguageFeature.AttributesToRightOfModuleKeyword, languageVersion60

@KevinRansom KevinRansom force-pushed the fscoreshipped branch 2 times, most recently from 8ef2163 to a663a1b Compare August 31, 2021 09:28
@vzarytovskii
Copy link
Member

Seems only one test failing:

+++ Diagnostics\async (UsingReturnInIfThenElse.fs) +++
--------------------------------------------------------
Results from hosted compiler
msg: Compiling
cmd: fsc   --warnaserror+ --test:ErrorRanges --flaterrors UsingReturnInIfThenElse.fs 
Exit code: 1
Error:     0
Microsoft (R) F# Compiler version 12.0.0.0 for F# 6.0
Copyright (c) Microsoft Corporation. All Rights Reserved.
(6,9-6,21): error FS0193: Type constraint mismatch. The type �    'Async<unit>'    �is not compatible with type�    'Async<int>'
--------------------------------------------------------
Compiling: [fsc   --warnaserror+ --test:ErrorRanges --flaterrors UsingReturnInIfThenElse.fs ]
Microsoft (R) F# Compiler version 12.0.0.0 for F# 6.0
Copyright (c) Microsoft Corporation. All Rights Reserved.

UsingReturnInIfThenElse.fs(6,9-6,21): error FS0193: Type constraint mismatch. The type �    'Async<unit>'    �is not compatible with type�    'Async<int>'
Compile Unexpectedly Failed: 256 
FAIL

@KevinRansom
Copy link
Contributor Author

@vzarytovskii , yes it has taken some thought to figure out tmagic for that.

@KevinRansom KevinRansom changed the title [WIP] - Update version numbers for FSharp.Core Update version numbers for FSharp.Core Sep 2, 2021
@KevinRansom
Copy link
Contributor Author

@vzarytovskii , @brettfo --- Assuming it passes this is ready

@dsyme
Copy link
Contributor

dsyme commented Sep 2, 2021

@KevinRansom I updated tests.fs to remove the test case corresponding to the deleted test files for array-no-dot-warnings in preview

type Person = { Name : string; Age : int; City : string }
let x = { Name = "Isaac", Age = 21, City = "London" }
"""
|> withLangVersion50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason this needed langversion 5.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dsyme , indeed yes and amazingly I can even remember why ... the test verified the behaviour without preview [Right Attribute Module Abbreviation without preview (compile)`]. I.e. the old F#5.0 behaviour, so ... this the test became with net50 [Right Attribute Module Abbreviation with version 5.0 (compile)] instead

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This... isn't the test you are referring to.

@dsyme dsyme mentioned this pull request Sep 2, 2021
14 tasks
@dsyme dsyme merged commit 31bf66b into dotnet:release/dev17.0 Sep 2, 2021
@KevinRansom KevinRansom deleted the fscoreshipped branch January 21, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants