Making several uses of Dictionary types be ConcurrentDictionary #10308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
saul
reviewed
Oct 21, 2020
8 tasks
En3Tho
reviewed
Oct 24, 2020
KevinRansom
approved these changes
Oct 26, 2020
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
Looks good, I do wonder, why a couple of tests changed the range, is it a quality of the dictionary type, or did something else subtle change.
...tOrientedTypeDefinitions/ClassTypes/MemberDeclarations/E_ClashingInstanceStaticProperties.fs
Show resolved
Hide resolved
...e/ObjectOrientedTypeDefinitions/ClassTypes/MemberDeclarations/E_PropertySameNameDiffArity.fs
Show resolved
Hide resolved
| ("Property", ["member"; "prop"])] | ||
| let results = [ for x in classTypeDefn.MembersFunctionsAndValues -> x.LogicalName, attribsOfSymbol x ] | ||
| [(".ctor", ["member"; "ctor"]); | ||
| ("get_Property", ["member"; "getter"]); |
Contributor
There was a problem hiding this comment.
Elsewhere these are indented.
dsyme
reviewed
Oct 27, 2020
dsyme
requested changes
Oct 27, 2020
Contributor
dsyme
left a comment
dsyme
left a comment
There was a problem hiding this comment.
Just a few changes requested
Contributor
|
I added this issue: #10342 to manage the possible dictionary storage order dependency. |
dsyme
approved these changes
Oct 27, 2020
Contributor
dsyme
left a comment
dsyme
left a comment
There was a problem hiding this comment.
I looked again and no changes are needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make the compiler more concurrent safe, we needed to make several uses of
Dictionarytypes beConcurrentDictionarytypes. Remaining uses ofDictionarytypes have a comment noting why they are safe.