Skip to content

US 1583733 Add missing language IDs - Part2 #15843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 20, 2019
Merged

US 1583733 Add missing language IDs - Part2 #15843

merged 9 commits into from
Nov 20, 2019

Conversation

@v-thpra
Copy link
Contributor

@v-thpra v-thpra commented Nov 13, 2019

User Story 1583733: Content Update: add missing language ID

Per the CATS Report from 11-11-2019 there are 98 code blocks without language IDs:

  • 48 of them were reviewed previously and it was decided that they should remain blank.
  • 50 of them are filled in by the changes in this PR. (several instances are cleared by changes in two include files)

@dotnet-bot dotnet-bot added this to the November 2019 milestone Nov 13, 2019
@v-thpra
Copy link
Contributor Author

v-thpra commented Nov 13, 2019 •
edited
Loading

@mairaw I'm assuming that the 9 reviewers are because I edited 2 include files in the Retargeting Changes for Migration from .NET Framework area? My change in each file was simple - I added a "class=language" value to a "code" element that was missing one. These accounted for 34 of the missing ID's.

Youssef1313
Youssef1313 requested changes Nov 14, 2019
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to #15689

@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Nov 14, 2019
tdykstra
tdykstra approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mairaw
mairaw reviewed Nov 14, 2019
View reviewed changes
mairaw
mairaw requested changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes @v-thpra. I've left you a few comments for you to consider.

@Youssef1313
Copy link
Member

Youssef1313 commented Nov 14, 2019 •
edited
Loading

@v-thpra, This is okay to use   to show the hierarchy, but I'd still use a backslash instead of the two spaces. (Except line 19, I'd remove the two spaces without adding a backslash)

@v-thpra
Copy link
Contributor Author

v-thpra commented Nov 14, 2019

@Youssef1313 Thanks, good suggestion! I added the backslashes and it looks good in preview.

@Youssef1313
Copy link
Member

Youssef1313 commented Nov 14, 2019

@v-thpra, hope it looks good in the localized versions as well. 😄

mairaw
mairaw reviewed Nov 19, 2019
View reviewed changes
@mairaw
Copy link
Contributor

mairaw commented Nov 20, 2019

Thank you @v-thpra!

@mairaw mairaw merged commit 57affcf into dotnet:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Youssef1313 Youssef1313 Youssef1313 requested changes

@tdykstra tdykstra tdykstra approved these changes

@mairaw mairaw mairaw approved these changes

Assignees

@v-thpra v-thpra

Labels

cli/subsvc cloud-native/subsvc dotnet-architecture/svc dotnet-framework/svc dotnet-fsharp/svc dotnet-spark/svc grpc/subsvc vendor-project Indicates the issue/pr is related to a vendor project. wcf/subsvc wpf/subsvc

Projects

None yet

Milestone

November 2019

Development

Successfully merging this pull request may close these issues.

6 participants

@v-thpra @Youssef1313 @mairaw @tdykstra @BillWagner @dotnet-bot