Skip to content

Fix loc issue #15689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 81 commits into from
Nov 12, 2019
Merged

Fix loc issue #15689

merged 81 commits into from
Nov 12, 2019

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Nov 4, 2019

This is how the article currently show in the localized versions:

image

I think the changes I made would fix that.

@Youssef1313 Youssef1313 requested a review from karelz as a code owner November 4, 2019 20:12
@dotnet-bot dotnet-bot added this to the November 2019 milestone Nov 4, 2019
@Youssef1313 Youssef1313 requested a review from mairaw as a code owner November 4, 2019 20:14
@Youssef1313
Update filter-element-for-add-for-listeners-for-source.md
9c4ef4d
@Youssef1313
Update cryptoclass-element.md
5bbdafe
@Youssef1313
Update clear-element-for-listeners-for-source.md
94f025c
@Youssef1313
Update remove-element-for-listeners-for-source.md
a298b75
@Youssef1313
Update filter-element-for-add-for-listeners-for-trace.md
21d3ef5
@Youssef1313
Update clear-element-for-bypasslist-network-settings.md
3c254e4
@Youssef1313
Update cryptoclass-element.md
1d04789
@Youssef1313
Update index.md
30a341f
@Youssef1313
Update clear-element-for-listeners-for-source.md
cfc56ff
@Youssef1313
Update filter-element-for-add-for-listeners-for-source.md
0791cd8
@Youssef1313
Update filter-element-for-add-for-listeners-for-trace.md
702e73a
@Youssef1313
Update remove-element-for-listeners-for-source.md
30a9002
@Youssef1313
Update remove-element-for-listeners-for-trace.md
aa44426
@Youssef1313
Update oidentry-element.md
22df83d
@Youssef1313
Update clear-element-for-listeners-for-trace.md
c510f69
@Youssef1313
Update filter-element-for-add-for-sharedlisteners.md
d5e7b00
@Youssef1313
Update clear-element-for-authenticationmodules-network-settings.md
60b169c
@Youssef1313
Update clear-element-for-connectionmanagement-network-settings.md
fd6602a
@Youssef1313
Update webproxyscript-element-network-settings.md
30d8bab
@Youssef1313
Update add-element-for-listeners-for-source.md
7a0c8f4
@Youssef1313
Update provideroption-element.md
1f31273
@Youssef1313
Update section-element.md
c8efbf4
@Youssef1313
Update index.md
3afd441
@Youssef1313
Copy link
Member Author

Youssef1313 commented Nov 4, 2019

This PR doesn't cover all the articles with this problem, but covered most of them.

@mairaw
Copy link
Contributor

mairaw commented Nov 12, 2019

@JasonCard after we merge this PR, can you make sure to follow up and see if the issue is addressed for loc? Thanks.

@mairaw mairaw added the loc Indicates issues that are about localized content [org][type][category] label Nov 12, 2019
mairaw
mairaw approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Youssef1313!

@mairaw mairaw merged commit ae70a0c into dotnet:master Nov 12, 2019
@JasonCard
Copy link
Contributor

JasonCard commented Nov 12, 2019

@mairaw @Youssef1313 Thank you for working on this fix. Yes, I'll follow up to check if this issue is resolved.

@Youssef1313 Youssef1313 deleted the patch-8 branch November 13, 2019 02:33
@Youssef1313 Youssef1313 mentioned this pull request Nov 14, 2019
Merged
Youssef1313 added a commit to Youssef1313/docs that referenced this pull request Nov 20, 2019
@Youssef1313
Fix loc issue (dotnet#15689)
b093082 
* Fix loc issue

* Update index.md

* Update filter-element-for-add-for-listeners-for-source.md

* Update cryptoclass-element.md

* Update clear-element-for-listeners-for-source.md

* Update remove-element-for-listeners-for-source.md

* Update filter-element-for-add-for-listeners-for-trace.md

* Update clear-element-for-bypasslist-network-settings.md

* Update cryptoclass-element.md

* Update index.md

* Update clear-element-for-listeners-for-source.md

* Update filter-element-for-add-for-listeners-for-source.md

* Update filter-element-for-add-for-listeners-for-trace.md

* Update remove-element-for-listeners-for-source.md

* Update remove-element-for-listeners-for-trace.md

* Update oidentry-element.md

* Update clear-element-for-listeners-for-trace.md

* Update filter-element-for-add-for-sharedlisteners.md

* Update clear-element-for-authenticationmodules-network-settings.md

* Update clear-element-for-connectionmanagement-network-settings.md

* Update webproxyscript-element-network-settings.md

* Update add-element-for-listeners-for-source.md

* Update provideroption-element.md

* Update section-element.md

* Update index.md

* Update index.md

* Update index.md

* Update oidmap-element.md

* Update add-element-for-connectionmanagement-network-settings.md

* Update clear-element-for-webrequestmodules-network-settings.md

* Update module-element-network-settings.md

* Update remove-element-for-authenticationmodules-network-settings.md

* Update remove-element-for-connectionmanagement-network-settings.md

* Update remove-element-for-webrequestmodules-network-settings.md

* Update smtp-element-network-settings.md

* Update add-element-for-listeners-for-trace.md

* Update cryptonamemapping-element.md

* Update add-element-for-authenticationmodules-network-settings.md

* Update add-element-for-webrequestmodules-network-settings.md

* Update bypasslist-element-network-settings.md

* Update clear-element-for-schemesettings-uri-settings.md

* Update defaulthttpcachepolicy-element-network-settings.md

* Update ipv6-element-network-settings.md

* Update performancecounter-element-network-settings.md

* Update clear-element-for-schemesettings-uri-settings.md

* Update defaulthttpcachepolicy-element-network-settings.md

* Update network-element-network-settings.md

* Update remove-element-for-schemesettings-uri-settings.md

* Update servicepointmanager-element-network-settings.md

* Update add-element-for-switches.md

* Update listeners-element-for-trace.md

* Update source-element.md

* Update compiler-element.md

* Update add-element-for-schemesettings-uri-settings.md

* Update defaultftpcachepolicy-element-network-settings.md

* Update httpwebrequest-element-network-settings.md

* Update proxy-element-network-settings.md

* Update clear-element-for-appsettings.md

* Update mailsettings-element-network-settings.md

* Update index.md

* Update add-element-for-custom-2.md

* Update add-element-for-appsettings.md

* Update remove-element-for-appsettings.md

* Update httplistener-element-network-settings.md

* Update socket-element-network-settings.md

* Update add-element-for-sharedlisteners.md

* Update cryptographysettings-element.md

* Update authenticationmodules-element-network-settings.md

* Update connectionmanagement-element-network-settings.md

* Update settings-element-network-settings.md

* Update assert-element.md

* Update sources-element.md

* Update switches-element.md

* Update clear-element-for-custom-2.md

* Update remove-element-for-configsections.md

* Update remove-element-for-custom-2.md

* Update mailsettings-element-network-settings.md

* Update sectiongroup-element-for-configsections.md

* Update linkedconfiguration-element.md

* Update compilers-element.md

* Fix lint error
@Youssef1313
Copy link
Member Author

Youssef1313 commented Nov 24, 2019

@mairaw, seems like this didn't fix the issue. 😢
This is strange because https://docs.microsoft.com/fr-fr/dotnet/framework/configure-apps/file-schema/runtime/ (and many others) renders correctly and the only difference I could find is the backslash thing.
https://github.com/dotnet/docs/blob/master/docs/framework/configure-apps/file-schema/runtime/index.md.

cc: @JasonCard

@JasonCard
Copy link
Contributor

JasonCard commented Nov 24, 2019

@Youssef1313 @mairaw I'm sorry for the delayed update on this. I was monitoring for this fix to publish for loc, but after investigation found that all of our localized update commits to dotnet/docs loc repos were failing since 11/12. We've found the root cause, but having difficulty resolving the issue, so currently working on a workaround to have all affected files committed and published by Monday. Will update.

@JasonCard
Copy link
Contributor

JasonCard commented Nov 25, 2019

@Youssef1313 @mairaw It's fixed now, although MT engine is adding an extra space before closing brackets, so I will follow up to see if that can be fixed on MT engine side:
fr-fr_fixed

@JasonCard
Copy link
Contributor

JasonCard commented Nov 25, 2019

@Youssef1313 @mairaw We have a question, are the escape/backslash chars () before the opening brackets (<) necessary? If those are removed, then those elements will be blocked from translation. If those are needed, then we can request for feature to update our transformer to block them even in those cases.

@mairaw
Copy link
Contributor

mairaw commented Dec 2, 2019

yes, they are; otherwise, they are not rendered @JasonCard

Compare here on the preview:

Look like it will render:

with the escape:
<configuration>

without the escape

@mairaw
Copy link
Contributor

mairaw commented Dec 2, 2019

This is how it was written:
image

@JasonCard
Copy link
Contributor

JasonCard commented Dec 2, 2019

Thank you for confirming. I will request for a feature to update our transformer to block those even with the escape char, so no fix is needed on your end. Will update on this.

@JasonCard
Copy link
Contributor

JasonCard commented Dec 2, 2019

@mairaw Would it be possible to use the inline no-loc md extensions like below?

# :::no-loc text=”<specifiedPickupDirectory>"::: Element (Network Settings)

[**:::no-loc text=”<configuration>":::**](../configuration-element.md)\

cc @mayast

@mairaw
Copy link
Contributor

mairaw commented Dec 3, 2019

Can you do one as a test @JasonCard?

@JasonCard JasonCard mentioned this pull request Dec 3, 2019
Closed
@JasonCard
Copy link
Contributor

JasonCard commented Dec 3, 2019

@mairaw Okay, I've opened this PR as test #16079.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mairaw mairaw mairaw approved these changes

@karelz karelz Awaiting requested review from karelz

Assignees

@Youssef1313 Youssef1313

Labels

dotnet-framework/svc loc Indicates issues that are about localized content [org][type][category] networking/subsvc

Projects

None yet

Milestone

November 2019

Development

Successfully merging this pull request may close these issues.

5 participants

@Youssef1313 @mairaw @JasonCard @BillWagner @dotnet-bot