Skip to content

Skip unfixable NavigationLock tests #63557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2025
Merged

Skip unfixable NavigationLock tests #63557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c7aa36
Split internal and external navigation tests for NavigationLock
oroztocil Sep 4, 2025
e16afac
Skip navigation tests that are currently not fixable
oroztocil Sep 5, 2025
3efa346
Simplify Skip comments
oroztocil Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions src/Components/test/E2ETest/ServerExecutionTests/NavigationLockPrerenderingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@ public NavigationLockPrerenderingTest(
public override Task InitializeAsync()
=> InitializeAsync(BrowserFixture.RoutingTestContext);

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/57153")]
public void NavigationIsLockedAfterPrerendering()
[Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/57153")]
public void ExternalNavigationIsLockedAfterPrerendering()
{
Navigate("/locked-navigation");

Expand All @@ -35,13 +34,24 @@ public void NavigationIsLockedAfterPrerendering()

BeginInteractivity();

// Assert that internal navigations are blocked
Browser.Click(By.Id("internal-navigation-link"));
Browser.Equal("Prevented navigations: 1", () => Browser.FindElement(By.Id("num-prevented-navigations")).Text);

// Assert that external navigations are blocked
Browser.Navigate().GoToUrl("about:blank");
Browser.SwitchTo().Alert().Dismiss();
Browser.Equal("Prevented navigations: 0", () => Browser.FindElement(By.Id("num-prevented-navigations")).Text);
}

[Fact]
public void InternalNavigationIsLockedAfterPrerendering()
{
Navigate("/locked-navigation");

// Assert that the component rendered successfully
Browser.Equal("Prevented navigations: 0", () => Browser.FindElement(By.Id("num-prevented-navigations")).Text);

BeginInteractivity();

// Assert that internal navigations are blocked
Browser.Click(By.Id("internal-navigation-link"));
Browser.Equal("Prevented navigations: 1", () => Browser.FindElement(By.Id("num-prevented-navigations")).Text);
}

Expand Down
3 changes: 1 addition & 2 deletions src/Components/test/E2ETest/Tests/RoutingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,8 +1155,7 @@ public void NavigationLock_HistoryNavigationWorks_AfterRefresh()
Browser.Equal("1", () => app.FindElement(By.Id("location-changed-count"))?.Text);
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/57153")]
[Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/57153")]
public void NavigationLock_CanBlockExternalNavigation()
{
SetUrlViaPushState("/");
Expand Down
Loading