Skip unfixable NavigationLock tests #63557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses unfixable test failures in NavigationLock functionality by skipping tests that rely on browser navigation confirmation alerts, which no longer work after a Selenium/ChromeDriver update.
- Replaces
QuarantinedTestattributes withFact(Skip = "...")to properly skip problematic tests - Splits one test method into separate internal and external navigation test methods
- Only skips the external navigation test that depends on the broken alert functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Components/test/E2ETest/Tests/RoutingTest.cs | Updates test attribute to skip external navigation test with proper reason |
| src/Components/test/E2ETest/ServerExecutionTests/NavigationLockPrerenderingTest.cs | Splits combined test into separate internal/external methods, skipping only external |
src/Components/test/E2ETest/ServerExecutionTests/NavigationLockPrerenderingTest.cs
Show resolved
Hide resolved
javiercn
approved these changes
Sep 5, 2025
oroztocil
deleted the
oroztocil/navigation-lock-internal-navigation-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NavigationLockcomponent to prevent external navigation. This feature cannot be tested properly after a Selenium/ChromeDriver update which caused the navigation confirmation alert to not be displayed.NavigationLocktest into two methods to cover internal and external navigation separately. Only the latter needs to be skipped.We agreed to use this as a temporary solution for #57153