Skip to content

Avoid unnecessary HealthStatus comparison #58176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Avoid unnecessary HealthStatus comparison #58176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/HealthChecks/Abstractions/src/HealthReport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,13 @@ private static HealthStatus CalculateAggregateStatus(IEnumerable<HealthReportEnt
if (currentValue > entry.Status)
{
currentValue = entry.Status;
}

if (currentValue == HealthStatus.Unhealthy)
{
// Game over, man! Game over!
// (We hit the worst possible status, so there's no need to keep iterating)
return currentValue;
if (currentValue == HealthStatus.Unhealthy)
{
// Game over, man! Game over!
Copy link
Contributor

@ladeak ladeak Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it worth considering replacing this comment with something more appropriate?

Copy link
Member

@amcasey amcasey Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I'd encourage people to write comments in this tone/register, but it wasn't introduced by this change and doesn't seem specifically inappropriate, so I'm okay with leaving it for now.

// (We hit the worst possible status, so there's no need to keep iterating)
return currentValue;
}
}
}

Expand Down
Loading