Avoid unnecessary HealthStatus comparison #58176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's only necessary to check `currentValue == HealthStatus.Unhealthy` when `currentValue` changes. During the first iteration, it is known to be `Healthy`.
ghost
added
the
area-networking
ladeak
reviewed
Oct 3, 2024
| return currentValue; | ||
| if (currentValue == HealthStatus.Unhealthy) | ||
| { | ||
| // Game over, man! Game over! |
There was a problem hiding this comment.
Does it worth considering replacing this comment with something more appropriate?
There was a problem hiding this comment.
I don't think I'd encourage people to write comments in this tone/register, but it wasn't introduced by this change and doesn't seem specifically inappropriate, so I'm okay with leaving it for now.
amcasey
approved these changes
Oct 3, 2024
captainsafia
pushed a commit
that referenced
this pull request
Dec 31, 2024
It's only necessary to check `currentValue == HealthStatus.Unhealthy` when `currentValue` changes. During the first iteration, it is known to be `Healthy`.
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
It's only necessary to check `currentValue == HealthStatus.Unhealthy` when `currentValue` changes. During the first iteration, it is known to be `Healthy`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary HealthStatus comparison
Description
It's only necessary to check
currentValue == HealthStatus.UnhealthywhencurrentValuechanges. During the first iteration, it is known to beHealthy.