Enable publishing in VMR

[NikolaMilosavljevic]

Contributes to dotnet/source-build#4101

Enables publishing in VMR.

[mmitche]

Was this not getting published before?

[NikolaMilosavljevic]

Not in VMR build, no.

[NikolaMilosavljevic]

OK - I see why - this is conditioned on PublishInstallerBaseVersion -

aspnetcore/eng/Publishing.props

Lines 34 to 35 in d9df235

	<_InstallersToPublish Include="$(ArtifactsDir)installers\**\*.version" UploadPathSegment="Runtime"
	Condition=" '$(PublishInstallerBaseVersion)' == 'true' " />

The property is only set in CI:

aspnetcore/.azure/pipelines/ci.yml

Line 350 in d9df235

/p:PublishInstallerBaseVersion=true

I should probably update the existing condition to also publish in VMR (i.e. when '$(DotNetBuildRepo)' == 'true')?

[mmitche]

Yes. When you see things like this, e.g. OS != Windows_NT or some kind of random flag that says SkipPublishingInstallers or something along those lines, it's that the repo's official build was publishing duplicates of assets between two legs. So Windows and OSX both produced Foo.Bar. The rule in our official builds is that when the merged manifest is generated, you can't have any duplicates from the input manifests.

This is not the rule in the VMR and we don't want to do this here. The asset selection that will happen at the merge point will be responsible for deciding which of a set of duplicates wins, and we'll add metadata to repo builds as necessary to feed the algorithm. This is in contrast to the official repo builds, which just avoid publishing altogether for duplicate assets.

So, much of your publishing.props changes in the repos can get a lot simpler (maybe go away altogether)

[NikolaMilosavljevic]

Fixed with 9dc87de