Skip to content

Conversation

@surayya-MS
Copy link
Member

[release 8.0] Fix radio button reset after submitting enhanced form

Manual backport of #51796

Description

This PR fixes resetting radio button checked property after submitting an enhanced form.

<form data-enhance>
    <input type="radio" />
    <button>Submit</button>
</form>

Workaround is to remove data-enhance attribute.

Fixes #51429

Customer Impact

Without this change customers will have bad experience using enhanced form that contains radio button. Radio button won't get reset after submitting the form.

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

This is a minor change. We have similar logic for checkbox approved #50991. There are unit and e2e tests for this change.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props

Fixes #51429

* fix radio button reset when submitting enhanced form

* rename test

* new fix

* Update src/Components/Web.JS/test/DomSync.test.ts

Co-authored-by: Steve Sanderson <[email protected]>

* Update src/Components/Web.JS/src/Rendering/DomMerging/DomSync.ts

Co-authored-by: Steve Sanderson <[email protected]>

---------

Co-authored-by: Steve Sanderson <[email protected]>
@surayya-MS surayya-MS added the Servicing-consider Shiproom approval is required for the issue label Nov 20, 2023
@surayya-MS surayya-MS requested a review from a team as a code owner November 20, 2023 17:33
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Nov 20, 2023
@ghost
Copy link

ghost commented Nov 20, 2023

Hi @surayya-MS. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@ghost ghost added this to the 8.0.x milestone Nov 20, 2023
@ghost
Copy link

ghost commented Nov 20, 2023

Hi @surayya-MS. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@surayya-MS surayya-MS changed the title [release 8.0] Fix radio button reset after submitting enhanced form [release/8.0] Fix radio button reset after submitting enhanced form Nov 20, 2023
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a backport. Otherwise, let me know.

@leecow leecow added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Nov 21, 2023
@ghost
Copy link

ghost commented Nov 21, 2023

Hi @surayya-MS. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

@leecow leecow modified the milestones: 8.0.x, 8.0.1 Nov 21, 2023
@mkArtakMSFT
Copy link
Contributor

@surayya-MS can you please resolve these conflict, so that I can merge this tomorrow? Thanks!

@AlexKovynev
Copy link

@surayya-MS :(

@mkArtakMSFT mkArtakMSFT merged commit 2c561c0 into dotnet:release/8.0 Nov 23, 2023
@ghost ghost modified the milestone: 8.0.1 Nov 23, 2023
@surayya-MS surayya-MS deleted the patch-reset-radio-button branch November 27, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-blazor Includes: Blazor, Razor Components Servicing-approved Shiproom has approved the issue

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants