Fix checkbox DOM sync #50991
Merged
Fix checkbox DOM sync #50991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
javiercn
approved these changes
Sep 28, 2023
mkArtakMSFT
added
the
Servicing-consider
|
Hi @SteveSandersonMS. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
mkArtakMSFT
added
Servicing-approved
|
Hi @SteveSandersonMS. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
11 tasks
11 tasks
mkArtakMSFT
pushed a commit
that referenced
this pull request
Nov 23, 2023
# [release 8.0] Fix radio button reset after submitting enhanced form Manual backport of #51796 ## Description This PR fixes resetting radio button checked property after submitting an enhanced form. ```html <form data-enhance> <input type="radio" /> <button>Submit</button> </form> ``` Workaround is to remove `data-enhance` attribute. Fixes #51429 ## Customer Impact Without this change customers will have bad experience using enhanced form that contains radio button. Radio button won't get reset after submitting the form. ## Regression? - [ ] Yes - [x] No [If yes, specify the version the behavior has regressed from] ## Risk - [ ] High - [ ] Medium - [x] Low This is a minor change. We have similar logic for checkbox approved #50991. There are unit and e2e tests for this change. ## Verification - [x] Manual (required) - [x] Automated ## Packaging changes reviewed? - [ ] Yes - [ ] No - [x] N/A ---- ## When servicing release/2.1 - [ ] Make necessary changes in eng/PatchConfig.props Fixes #51429
3dots
pushed a commit
to 3dots/aspnetcore-Web.JS
that referenced
this pull request
Feb 19, 2024
# [release 8.0] Fix radio button reset after submitting enhanced form Manual backport of dotnet/aspnetcore#51796 ## Description This PR fixes resetting radio button checked property after submitting an enhanced form. ```html <form data-enhance> <input type="radio" /> <button>Submit</button> </form> ``` Workaround is to remove `data-enhance` attribute. Fixes #51429 ## Customer Impact Without this change customers will have bad experience using enhanced form that contains radio button. Radio button won't get reset after submitting the form. ## Regression? - [ ] Yes - [x] No [If yes, specify the version the behavior has regressed from] ## Risk - [ ] High - [ ] Medium - [x] Low This is a minor change. We have similar logic for checkbox approved dotnet/aspnetcore#50991. There are unit and e2e tests for this change. ## Verification - [x] Manual (required) - [x] Automated ## Packaging changes reviewed? - [ ] Yes - [ ] No - [x] N/A ---- ## When servicing release/2.1 - [ ] Make necessary changes in eng/PatchConfig.props Fixes #51429
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix checkbox DOM sync
Unbreaks checkboxes with custom value attributes.
Description
There was a trivial logic error in the DOM syncing code, causing the
valueattribute on checkboxes to get wrongly overwritten in a certain case (if there was a custom value attribute andcheckedwas unchanged).Fixes #50995
Customer Impact
In some cases, checkbox values would get corrupted after an enhanced navigation. This would break form functionality.
The specific scenario was "checkboxes with a custom value attribute, when an enhanced nav leaves the
checkedstate unchanged".Regression?
[If yes, specify the version the behavior has regressed from]
Risk
Very low because it's a tiny code edit, and only affects a very specific scenario, and the old logic was (in retrospect) definitely incorrect.
Verification
Packaging changes reviewed?