Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 3, 2023

Backport of #47542 to release/7.0

/cc @wtgodbe

Pass /norestart to Hosting Bundle nested bundles

Ensure that when /norestart is passed on the command line to the hosting bundle, the user sees the expected behavior (no restart)

Description

WiX doesn't pass command line args to nested bundles/packages, since the nested package could be any arbitrary .exe. This means when that today, when the user passes /norestart to the hosting bundle in a repair or uninstall command, they'll still be prompted to restart. Always passing /norestart to these commands will give us the behavior that users would expect (/norestart = no restart, no /norestart = restart, prompted from the hosting bundle itself).

Fixes #47544

Customer Impact

Fulfills request from the Office team

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

These /norestart args will only have any effect when the user passes /norestart to the hosting bundle. The risk is if there's a scenario I haven't thought of.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 3, 2023
@ghost ghost added this to the 7.0.x milestone Apr 3, 2023
@ghost
Copy link

ghost commented Apr 3, 2023

Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@ghost
Copy link

ghost commented Apr 3, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@wtgodbe wtgodbe requested review from a team and joeloff April 3, 2023 17:10
@wtgodbe wtgodbe added the Servicing-consider Shiproom approval is required for the issue label Apr 3, 2023
@ghost
Copy link

ghost commented Apr 3, 2023

Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@leecow leecow added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Apr 4, 2023
@ghost
Copy link

ghost commented Apr 4, 2023

Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

@leecow leecow modified the milestones: 7.0.x, 7.0.6 Apr 4, 2023
@wtgodbe wtgodbe merged commit 4110466 into release/7.0 Apr 4, 2023
@wtgodbe wtgodbe deleted the backport/pr-47542-to-release/7.0 branch April 4, 2023 21:01
@ghost ghost modified the milestone: 7.0.6 Apr 4, 2023
@rbhanda rbhanda modified the milestones: 7.0.6, 7.0.7 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants