Pass /norestart to Hosting Bundle nested bundles #47542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
Member
Author
|
/backport to release/7.0 |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/aspnetcore/actions/runs/4599333447 |
11 tasks
joeloff
approved these changes
Apr 3, 2023
11 tasks
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a request from the Office team - they pass
/norestartto the repair command of the hosting bundle, but still have to restart because args don't get passed through to inner bundles. We don't want to blindly pass through args, but I think it's reasonable to always pass/norestartto the inner bundles (If the user doesn't pass/norestartto the hosting bundle, we'll restart, and if they do pass it, we won't).To be backported to 6 & 7
Part of #47544