Ensure AccessToken is not trimmed away
#40274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #32357 <details> ``` crit: Microsoft.AspNetCore.Components.WebAssembly.Rendering.WebAssemblyRenderer[100] Unhandled exception rendering component: An exception occurred executing JS interop: DeserializeNoConstructor, JsonConstructorAttribute, Microsoft.AspNetCore.Components.WebAssembly.Authentication.AccessToken Path: $.token | LineNumber: 0 | BytePositionInLine: 29.. See InnerException for more details. Microsoft.JSInterop.JSException: An exception occurred executing JS interop: DeserializeNoConstructor, JsonConstructorAttribute, Microsoft.AspNetCore.Components.WebAssembly.Authentication.AccessToken Path: $.token | LineNumber: 0 | BytePositionInLine: 29.. See InnerException for more details. ---> System.NotSupportedException: DeserializeNoConstructor, JsonConstructorAttribute, Microsoft.AspNetCore.Components.WebAssembly.Authentication.AccessToken Path: $.token | LineNumber: 0 | BytePositionInLine: 29. ---> System.NotSupportedException: DeserializeNoConstructor, JsonConstructorAttribute, Microsoft.AspNetCore.Components.WebAssembly.Authentication.AccessToken Exception_EndOfInnerExceptionStack at System.Text.Json.ThrowHelper.ThrowNotSupportedException(ReadStack& , Utf8JsonReader& , NotSupportedException ) at System.Text.Json.ThrowHelper.ThrowNotSupportedException_DeserializeNoConstructor(Type , Utf8JsonReader& , ReadStack& ) at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1[[Microsoft.AspNetCore.Components.WebAssembly.Authentication.AccessToken, Microsoft.AspNetCore.Components.WebAssembly.Authentication, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]].OnTryRead(Utf8JsonReader& , Type , JsonSerializerOptions , ReadStack& , AccessToken& ) at System.Text.Json.Serialization.JsonConverter`1[[Microsoft.AspNetCore.Components.WebAssembly.Authentication.AccessToken, Microsoft.AspNetCore.Components.WebAssembly.Authentication, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]].TryRead(Utf8JsonReader& , Type , JsonSerializerOptions , ReadStack& , AccessToken& ) at System.Text.Json.Serialization.Metadata.JsonPropertyInfo`1[[Microsoft.AspNetCore.Components.WebAssembly.Authentication.AccessToken, Microsoft.AspNetCore.Components.WebAssembly.Authentication, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]].ReadJsonAndSetMember(Object , ReadStack& , Utf8JsonReader& ) at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1[[Microsoft.AspNetCore.Components.WebAssembly.Authentication.InternalAccessTokenResult, Microsoft.AspNetCore.Components.WebAssembly.Authentication, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]].OnTryRead(Utf8JsonReader& , Type , JsonSerializerOptions , ReadStack& , InternalAccessTokenResult& ) at System.Text.Json.Serialization.JsonConverter`1[[Microsoft.AspNetCore.Components.WebAssembly.Authentication.InternalAccessTokenResult, Microsoft.AspNetCore.Components.WebAssembly.Authentication, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]].TryRead(Utf8JsonReader& , Type , JsonSerializerOptions , ReadStack& , InternalAccessTokenResult& ) at System.Text.Json.Serialization.JsonConverter`1[[Microsoft.AspNetCore.Components.WebAssembly.Authentication.InternalAccessTokenResult, Microsoft.AspNetCore.Components.WebAssembly.Authentication, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]].ReadCore(Utf8JsonReader& , JsonSerializerOptions , ReadStack& ) at System.Text.Json.Serialization.JsonConverter`1[[Microsoft.AspNetCore.Components.WebAssembly.Authentication.InternalAccessTokenResult, Microsoft.AspNetCore.Components.WebAssembly.Authentication, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]].ReadCoreAsObject(Utf8JsonReader& , JsonSerializerOptions , ReadStack& ) at System.Text.Json.JsonSerializer.ReadCore[Object](JsonConverter , Utf8JsonReader& , JsonSerializerOptions , ReadStack& ) at System.Text.Json.JsonSerializer.Read[Object](Utf8JsonReader& , JsonTypeInfo ) at System.Text.Json.JsonSerializer.Deserialize(Utf8JsonReader& , Type , JsonSerializerOptions ) at Microsoft.JSInterop.JSRuntime.EndInvokeJS(Int64 , Boolean , Utf8JsonReader& ) Exception_EndOfInnerExceptionStack at Microsoft.JSInterop.JSRuntime.<InvokeAsync>d__16`1[[Microsoft.AspNetCore.Components.WebAssembly.Authentication.InternalAccessTokenResult, Microsoft.AspNetCore.Components.WebAssembly.Authentication, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]].MoveNext() at Microsoft.AspNetCore.Components.WebAssembly.Authentication.RemoteAuthenticationService`3.<RequestAccessToken>d__22[[Microsoft.AspNetCore.Components.WebAssembly.Authentication.RemoteAuthenticationState, Microsoft.AspNetCore.Components.WebAssembly.Authentication, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60],[Microsoft.AspNetCore.Components.WebAssembly.Authentication.RemoteUserAccount, Microsoft.AspNetCore.Components.WebAssembly.Authentication, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60],[Microsoft.AspNetCore.Components.WebAssembly.Authentication.ApiAuthorizationProviderOptions, Microsoft.AspNetCore.Components.WebAssembly.Authentication, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]].MoveNext() at Microsoft.AspNetCore.Components.WebAssembly.Authentication.AuthorizationMessageHandler.SendAsync(HttpRequestMessage , CancellationToken ) at Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler.SendAsync(HttpRequestMessage , CancellationToken ) at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage , HttpCompletionOption , CancellationTokenSource , Boolean , CancellationTokenSource , CancellationToken ) at System.Net.Http.Json.HttpClientJsonExtensions.<GetFromJsonAsyncCore>d__13`1[[BlazorApp1.Shared.WeatherForecast[], BlazorApp1.Shared, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]].MoveNext() at BlazorApp1.Client.Pages.FetchData.OnInitializedAsync() at Microsoft.AspNetCore.Components.ComponentBase.RunInitAndSetParametersAsync() at Microsoft.AspNetCore.Components.RenderTree.Renderer.GetErrorHandledTask(Task , ComponentState ) u @ blazor.webassembly.js:1 (anonymous) @ blazor.webassembly.js:1 kt @ blazor.webassembly.js:1 mono_wasm_invoke_js_blazor @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:3 _mono_wasm_invoke_js_blazor @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:12 $func194 @ 008c609a:0x17786 $func165 @ 008c609a:0x16d84 $func105 @ 008c609a:0x71fc $func104 @ 008c609a:0x60b7 $func7266 @ 008c609a:0x18187e $func1535 @ 008c609a:0x715af $func1539 @ 008c609a:0x71cda $mono_wasm_invoke_method @ 008c609a:0x1b3a1f Module._mono_wasm_invoke_method @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:12 _Microsoft_AspNetCore_Components_WebAssembly__Microsoft_AspNetCore_Components_WebAssembly_Services_DefaultWebAssemblyJSRuntime_EndInvokeJS @ _Microsoft_AspNetCore_Components_WebAssembly__Microsoft_AspNetCore_Components_WebAssembly_Services_DefaultWebAssemblyJSRuntime_EndInvokeJS:23 endInvokeJSFromDotNet @ blazor.webassembly.js:1 (anonymous) @ blazor.webassembly.js:1 Promise.then (async) beginInvokeJSFromDotNet @ blazor.webassembly.js:1 kt @ blazor.webassembly.js:1 mono_wasm_invoke_js_blazor @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:3 _mono_wasm_invoke_js_blazor @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:12 $func194 @ 008c609a:0x17786 $func165 @ 008c609a:0x16d84 $func105 @ 008c609a:0x71fc $func104 @ 008c609a:0x60b7 $func7266 @ 008c609a:0x18187e $func1535 @ 008c609a:0x715af $func1539 @ 008c609a:0x71cda $mono_wasm_invoke_method @ 008c609a:0x1b3a1f Module._mono_wasm_invoke_method @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:12 _Microsoft_AspNetCore_Components_WebAssembly__Microsoft_AspNetCore_Components_WebAssembly_Services_DefaultWebAssemblyJSRuntime_EndInvokeJS @ _Microsoft_AspNetCore_Components_WebAssembly__Microsoft_AspNetCore_Components_WebAssembly_Services_DefaultWebAssemblyJSRuntime_EndInvokeJS:23 endInvokeJSFromDotNet @ blazor.webassembly.js:1 (anonymous) @ blazor.webassembly.js:1 Promise.then (async) beginInvokeJSFromDotNet @ blazor.webassembly.js:1 kt @ blazor.webassembly.js:1 mono_wasm_invoke_js_blazor @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:3 _mono_wasm_invoke_js_blazor @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:12 $func194 @ 008c609a:0x17786 $func165 @ 008c609a:0x16d84 $func105 @ 008c609a:0x71fc $func104 @ 008c609a:0x60b7 $func7266 @ 008c609a:0x18187e $func1535 @ 008c609a:0x715af $func1533 @ 008c609a:0x71521 $func992 @ 008c609a:0x530ae $func194 @ 008c609a:0x1773f $func165 @ 008c609a:0x16d84 $func105 @ 008c609a:0x71fc $func104 @ 008c609a:0x60b7 $func7266 @ 008c609a:0x18187e $func1535 @ 008c609a:0x715af $func1539 @ 008c609a:0x71cda $mono_wasm_invoke_method @ 008c609a:0x1b3a1f Module._mono_wasm_invoke_method @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:12 _Microsoft_AspNetCore_Components_WebAssembly__Microsoft_AspNetCore_Components_WebAssembly_Services_DefaultWebAssemblyJSRuntime_EndInvokeJS @ _Microsoft_AspNetCore_Components_WebAssembly__Microsoft_AspNetCore_Components_WebAssembly_Services_DefaultWebAssemblyJSRuntime_EndInvokeJS:23 endInvokeJSFromDotNet @ blazor.webassembly.js:1 (anonymous) @ blazor.webassembly.js:1 Promise.then (async) beginInvokeJSFromDotNet @ blazor.webassembly.js:1 kt @ blazor.webassembly.js:1 mono_wasm_invoke_js_blazor @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:3 _mono_wasm_invoke_js_blazor @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:12 $func194 @ 008c609a:0x17786 $func165 @ 008c609a:0x16d84 $func105 @ 008c609a:0x71fc $func104 @ 008c609a:0x60b7 $func7266 @ 008c609a:0x18187e $func1535 @ 008c609a:0x715af $func1539 @ 008c609a:0x71cda $mono_wasm_invoke_method @ 008c609a:0x1b3a1f Module._mono_wasm_invoke_method @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:12 _Microsoft_AspNetCore_Components_WebAssembly__Microsoft_AspNetCore_Components_WebAssembly_Services_DefaultWebAssemblyJSRuntime_EndInvokeJS @ _Microsoft_AspNetCore_Components_WebAssembly__Microsoft_AspNetCore_Components_WebAssembly_Services_DefaultWebAssemblyJSRuntime_EndInvokeJS:23 endInvokeJSFromDotNet @ blazor.webassembly.js:1 (anonymous) @ blazor.webassembly.js:1 Promise.then (async) beginInvokeJSFromDotNet @ blazor.webassembly.js:1 kt @ blazor.webassembly.js:1 mono_wasm_invoke_js_blazor @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:3 _mono_wasm_invoke_js_blazor @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:12 $func194 @ 008c609a:0x17786 $func165 @ 008c609a:0x16d84 $func105 @ 008c609a:0x71fc $func104 @ 008c609a:0x60b7 $func7266 @ 008c609a:0x18187e $func1535 @ 008c609a:0x715af $func1539 @ 008c609a:0x71cda $mono_wasm_invoke_method @ 008c609a:0x1b3a1f Module._mono_wasm_invoke_method @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:12 _Microsoft_AspNetCore_Components_WebAssembly__Microsoft_AspNetCore_Components_WebAssembly_Services_DefaultWebAssemblyJSRuntime_EndInvokeJS @ _Microsoft_AspNetCore_Components_WebAssembly__Microsoft_AspNetCore_Components_WebAssembly_Services_DefaultWebAssemblyJSRuntime_EndInvokeJS:23 endInvokeJSFromDotNet @ blazor.webassembly.js:1 (anonymous) @ blazor.webassembly.js:1 Promise.then (async) beginInvokeJSFromDotNet @ blazor.webassembly.js:1 kt @ blazor.webassembly.js:1 mono_wasm_invoke_js_blazor @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:3 _mono_wasm_invoke_js_blazor @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:12 $func194 @ 008c609a:0x17786 $func165 @ 008c609a:0x16d84 $func105 @ 008c609a:0x71fc $func104 @ 008c609a:0x60b7 $func7266 @ 008c609a:0x18187e $func1535 @ 008c609a:0x715af $func1539 @ 008c609a:0x71cda $mono_wasm_invoke_method @ 008c609a:0x1b3a1f Module._mono_wasm_invoke_method @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:12 _Microsoft_AspNetCore_Components_WebAssembly__Microsoft_AspNetCore_Components_WebAssembly_Services_DefaultWebAssemblyJSRuntime_EndInvokeJS @ _Microsoft_AspNetCore_Components_WebAssembly__Microsoft_AspNetCore_Components_WebAssembly_Services_DefaultWebAssemblyJSRuntime_EndInvokeJS:23 endInvokeJSFromDotNet @ blazor.webassembly.js:1 (anonymous) @ blazor.webassembly.js:1 Promise.then (async) beginInvokeJSFromDotNet @ blazor.webassembly.js:1 kt @ blazor.webassembly.js:1 mono_wasm_invoke_js_blazor @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:3 _mono_wasm_invoke_js_blazor @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:12 $func194 @ 008c609a:0x17786 $func165 @ 008c609a:0x16d84 $func105 @ 008c609a:0x71fc $func104 @ 008c609a:0x60b7 $func7266 @ 008c609a:0x18187e $func1535 @ 008c609a:0x715af $func1539 @ 008c609a:0x71cda $mono_wasm_invoke_method @ 008c609a:0x1b3a1f Module._mono_wasm_invoke_method @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:12 BINDINGS_SetTaskSourceResult @ BINDINGS_SetTaskSourceResult:24 o.<computed> @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:3 (anonymous) @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:3 Promise.then (async) _wrap_js_thenable_as_task @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:3 _js_to_mono_obj @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:3 js_to_mono_obj @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:3 (anonymous) @ blazor.webassembly.js:1 kt @ blazor.webassembly.js:1 mono_wasm_invoke_js_blazor @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:3 _mono_wasm_invoke_js_blazor @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:12 $func194 @ 008c609a:0x17786 $func165 @ 008c609a:0x16d84 $func105 @ 008c609a:0x71fc $func104 @ 008c609a:0x60b7 $func7266 @ 008c609a:0x18187e $func1535 @ 008c609a:0x715af $func1539 @ 008c609a:0x71cda $mono_wasm_invoke_method @ 008c609a:0x1b3a1f Module._mono_wasm_invoke_method @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:12 _call_method_with_converted_args @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:3 call_method @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:3 (anonymous) @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:3 mono_call_assembly_entry_point @ dotnet.7.0.0-preview.2.22103.2.n9t5r83lkh.js:3 callEntryPoint @ blazor.webassembly.js:1 Nt @ blazor.webassembly.js:1 await in Nt (async) (anonymous) @ blazor.webassembly.js:1 (anonymous) @ blazor.webassembly.js:1 ``` </details>
ghost
added
the
TanayParikh
commented
Feb 16, 2022
| } | ||
|
|
||
| /// <inheritdoc /> | ||
| [DynamicDependency(JsonSerialized, typeof(AccessToken))] |
Contributor
Author
There was a problem hiding this comment.
Does it matter where exactly we add the DynamicDependency?
Contributor
There was a problem hiding this comment.
The way to think about it is - if the trimmer decides not to trim away RequestAccessToken because it's called by user code directly or indirectly, then the types declared as dynamic dependencies do not get trimmed. Usually you want to put it close to where the referenced type gets used so you're not rooting more things than you need to. I'm guessing in this case InternalAccessTokenResult references AccessToken?
Contributor
Author
There was a problem hiding this comment.
I'm guessing in this case
InternalAccessTokenResultreferencesAccessToken?
Exactly, that's what's in the stack trace. But I wasn't sure if it needed to be on a method to work. Thanks for the clarification!
at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1[[Microsoft.AspNetCore.Components.WebAssembly.Authentication.InternalAccessTokenResult, Microsoft.AspNetCore.Components.WebAssembly.Authentication, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]].OnTryRead(Utf8JsonReader& , Type , JsonSerializerOptions , ReadStack& , InternalAccessTokenResult& )
at System.Text.Json.Serialization.JsonConverter`1[[Microsoft.AspNetCore.Components.WebAssembly.Authentication.InternalAccessTokenResult, Microsoft.AspNetCore.Components.WebAssembly.Authentication, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]].TryRead(Utf8JsonReader& , Type , JsonSerializerOptions , ReadStack& , InternalAccessTokenResult& )
at System.Text.Json.Serialization.JsonConverter`1[[Microsoft.AspNetCore.Components.WebAssembly.Authentication.InternalAccessTokenResult, Microsoft.AspNetCore.Components.WebAssembly.Authentication, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]].ReadCore(Utf8JsonReader& , JsonSerializerOptions , ReadStack& )
at System.Text.Json.Serialization.JsonConverter`1[[Microsoft.AspNetCore.Components.WebAssembly.Authentication.InternalAccessTokenResult, Microsoft.AspNetCore.Components.WebAssembly.Authentication, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]].ReadCoreAsObject(Utf8JsonReader& , JsonSerializerOptions , ReadStack& )
at System.Text.Json.JsonSerializer.ReadCore[Object](JsonConverter , Utf8JsonReader& , JsonSerializerOptions , ReadStack& )
Contributor
Author
There was a problem hiding this comment.
But I wasn't sure if it needed to be on a method to work.
Looks like that is in fact the case:
Attribute 'DynamicDependency' is not valid on this declaration type. It is only valid on 'constructor, method, field' declarations.
Contributor
Author
There was a problem hiding this comment.
Reverted back, any objections?
pranavkm
approved these changes
Feb 16, 2022
Contributor
Author
|
CI failing on runtime changes; fixed via #40268. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/aspnet/AspNetCore-ManualTests/issues/1182
Likely a result of #39838
Based on #32398