-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Annotate WebAssembly.Authentication #39838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TanayParikh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some formatting nits
...Components/WebAssembly/Authentication.Msal/src/MsalWebAssemblyServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
...ssembly.Authentication/src/Microsoft.AspNetCore.Components.WebAssembly.Authentication.csproj
Outdated
Show resolved
Hide resolved
...omponents/WebAssembly/WebAssembly.Authentication/src/Services/RemoteAuthenticationService.cs
Outdated
Show resolved
Hide resolved
...embly/WebAssembly.Authentication/src/WebAssemblyAuthenticationServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
|
Authentication.MSAL was already annotated for trimming. However WebAssembly.Authentication previously wasn't. Investigating this issue, the underlying issue was that our JSRuntime.Invoke* APIs aren't annotated accurately. Essentially, all of the In this particular case, |
Co-authored-by: Tanay Parikh <[email protected]>
…mblyServiceCollectionExtensions.cs Co-authored-by: Tanay Parikh <[email protected]>
Do we have a tracking issue for this? |
|
Great that you were able to resolve the issue with the authentication libraries!
By that do you mean we're unable to annotate them because the right kinds of annotation don't exist and we'd need to ask for new compiler features, or do you mean we can and should put |
Fixes #30751
Fixes #35162