Skip to content

Set WebApplication.New().ServerFeatures #40183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Set WebApplication.New().ServerFeatures #40183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53f1342
Set WebApplication.New().ServerFeatures
feiyun0112 Feb 13, 2022
75ba777
Update src/DefaultBuilder/src/WebApplication.cs
pranavkm Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DefaultBuilder/src/WebApplication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public sealed class WebApplication : IHost, IApplicationBuilder, IEndpointRouteB
internal WebApplication(IHost host)
{
_host = host;
ApplicationBuilder = new ApplicationBuilder(host.Services);
ApplicationBuilder = new ApplicationBuilder(host.Services, ServerFeatures);
Logger = host.Services.GetRequiredService<ILoggerFactory>().CreateLogger(Environment.ApplicationName);

Properties[GlobalEndpointRouteBuilderKey] = this;
Expand Down
10 changes: 10 additions & 0 deletions src/DefaultBuilder/test/Microsoft.AspNetCore.Tests/WebApplicationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ namespace Microsoft.AspNetCore.Tests;

public class WebApplicationTests
{
[Fact]
public async Task WebApplicationBuilder_New()
{
var builder = WebApplication.CreateBuilder(new string[] { "--urls", "http://localhost:5001" });

await using var app = builder.Build();
var newApp = (app as IApplicationBuilder).New();
Assert.NotNull(newApp.ServerFeatures);
}

[Fact]
public async Task WebApplicationBuilderConfiguration_IncludesCommandLineArguments()
{
Expand Down