Skip to content

Set WebApplication.New().ServerFeatures #40183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2022
Merged

Set WebApplication.New().ServerFeatures #40183

merged 2 commits into from
Feb 17, 2022

Conversation

@feiyun0112
Copy link
Contributor

@feiyun0112 feiyun0112 commented Feb 13, 2022

fix #40042

@ghost ghost added area-runtime community-contribution Indicates that the PR has been added by a community member labels Feb 13, 2022
Tratcher
Tratcher approved these changes Feb 15, 2022
View reviewed changes
@feiyun0112 feiyun0112 requested a review from Tratcher February 16, 2022 04:08
@Tratcher
Copy link
Member

Tratcher commented Feb 16, 2022

@pranavkm @HaoK why would this build fail with identity nullability issues?

@Tratcher Tratcher enabled auto-merge (squash) February 16, 2022 15:50
@Tratcher
Copy link
Member

Tratcher commented Feb 16, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 16, 2022

Azure Pipelines successfully started running 3 pipeline(s).

@feiyun0112 feiyun0112 requested a review from Tratcher February 17, 2022 08:39
@Tratcher
Copy link
Member

Tratcher commented Feb 17, 2022

Closing and re-opening to fix the cla check.

@Tratcher Tratcher closed this Feb 17, 2022
auto-merge was automatically disabled February 17, 2022 16:52

Pull request was closed

@Tratcher Tratcher reopened this Feb 17, 2022
@Tratcher Tratcher enabled auto-merge (squash) February 17, 2022 16:52
@campersau
Copy link
Contributor

campersau commented Feb 17, 2022

Are you considering backporting this to 6.0 ?

@Tratcher
Copy link
Member

Tratcher commented Feb 17, 2022

Are you considering backporting this to 6.0 ?

Unlikely, given there's a workaround. Is this impacting you on 6.0?

@Tratcher Tratcher merged commit ce292b3 into dotnet:main Feb 17, 2022
@ghost ghost added this to the 7.0-preview3 milestone Feb 17, 2022
@Tratcher
Copy link
Member

Tratcher commented Feb 17, 2022

Thanks @feiyun0112

@feiyun0112 feiyun0112 deleted the fix-40042 branch February 18, 2022 00:31
@campersau campersau mentioned this pull request Jul 28, 2022
Closed
1 task
campersau pushed a commit to campersau/AspNetCore that referenced this pull request Jul 29, 2022
@feiyun0112 @campersau
Set WebApplication.New().ServerFeatures (dotnet#40183)
772ada0
@adityamandaleeka adityamandaleeka mentioned this pull request Jul 29, 2022
Merged
10 tasks
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees

@Tratcher Tratcher

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

7.0-preview3

Development

Successfully merging this pull request may close these issues.

WebApplication.New().ServerFeatures is null

6 participants

@feiyun0112 @Tratcher @campersau @adityamandaleeka @amcasey @pranavkm