Add nullability to Identity / Identity.UI #40167
Conversation
ghost
added
the
pranavkm
force-pushed
the
nullable-identity
branch
from
e0be3b8 to
60310df
Compare
There was a problem hiding this comment.
Slight functional change.
| /// </summary> | ||
| [BindProperty] | ||
| public InputModel Input { get; set; } | ||
| public InputModel Input { get; set; } = default!; |
There was a problem hiding this comment.
I mentioned this to @DamianEdwards - the Input property is only bound in OnPost and it would make more sense to mark this as nullable. However this has two annoying issues:
a) ModelExpression - which is what you get if you do <input asp-for"Input.Name" /> is a expression tree which does not support using null propagation. MVC handles null-values in the expression tree, but as a user you're forced to use a null-forgiveness operator which doesn't feel nice: <input asp-for"Input!.Name" />
b) You end up having to also assert that this value is non-null in every OnPost.
Making it non-nullable seems like a cheeky but less painful way to go about this.
2 participants
No description provided.